From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH] Re-re-re-fix common tail optimization Date: Mon, 17 Dec 2007 12:51:29 +0000 (GMT) Message-ID: References: <20071215155150.GA24810@coredump.intra.peff.net> <7vprx7n90t.fsf@gitster.siamese.dyndns.org> <20071215200202.GA3334@sigill.intra.peff.net> <20071216070614.GA5072@sigill.intra.peff.net> <7v8x3ul927.fsf@gitster.siamese.dyndns.org> <7v7ijejq6j.fsf@gitster.siamese.dyndns.org> <20071216212104.GA32307@coredump.intra.peff.net> <7v3au2joo2.fsf_-_@gitster.siamese.dyndns.org> <20071216221545.GA32596@coredump.intra.peff.net> <7vtzmii8io.fsf@gitster.siamese.dyndns.org> <20071216222919.GA2260@coredump.intra.peff.net> <36E62F9B-26FF-4DC0-99B8-D6DC2B960E67@wincent.com> <57245FA1-361B-4333-B490-A2CC99ED4F9C@wincent.com> <476669A7.1050407@viscovery.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Wincent Colaiuta , Jeff King , Junio C Hamano , Linus Torvalds , git@vger.kernel.org To: Johannes Sixt X-From: git-owner@vger.kernel.org Mon Dec 17 13:52:13 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1J4FS3-0002vk-Tq for gcvg-git-2@gmane.org; Mon, 17 Dec 2007 13:52:08 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753442AbXLQMvp (ORCPT ); Mon, 17 Dec 2007 07:51:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753168AbXLQMvp (ORCPT ); Mon, 17 Dec 2007 07:51:45 -0500 Received: from mail.gmx.net ([213.165.64.20]:60388 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753114AbXLQMvo (ORCPT ); Mon, 17 Dec 2007 07:51:44 -0500 Received: (qmail invoked by alias); 17 Dec 2007 12:51:42 -0000 Received: from unknown (EHLO [138.251.11.74]) [138.251.11.74] by mail.gmx.net (mp005) with SMTP; 17 Dec 2007 13:51:42 +0100 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1+6BVVr1fy6ee0udfbg+Iljtx5a/fNR9nELveO6jX FlL+Ai70lqYiak X-X-Sender: gene099@racer.site In-Reply-To: <476669A7.1050407@viscovery.net> X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Mon, 17 Dec 2007, Johannes Sixt wrote: > Wincent Colaiuta schrieb: > > El 17/12/2007, a las 12:57, Johannes Schindelin escribi?: > > > >> Hmm. There is some chicken-and-egg problem here (I read the thread, but > >> did not really see a problem, as I assumed that _other_ tests would > >> assure > >> that "git diff --no-index" works as expected). > >> > >> But as at least one released version of GNU diff has a pretty serious > >> bug, > >> I would rather not rely too much on diff. (BTW this was the reason I > >> wanted --no-index so badly.) > >> > >> So yeah, the second "diff" cannot be "git diff". Maybe "cmp", but not > >> "git diff". > > > > Well cmp would be fine as well, seeing all we want is a boolean "is > > this the same or not" answer. (I'm not familiar with the GNU diff bug > > you speak of, but was it so bad that it couldn't even get *that* > > answer right?) > > Heh, there's at least one distribution out there (Suse 10.1) that comes > with a *cmp* that doesn't get that answer right if its output is > connected to /dev/null, which is the case when you simply 'make test'. Yeah. That's what it was. I even posted a patch to GNU diff, only to find out that it was already fixed in CVS. Sigh. Ciao, Dscho