From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Pieter de Bie <pdebie@ai.rug.nl>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
git@vger.kernel.org, gitster@pobox.com
Subject: [PATCH] rebase -p -i: handle "no changes" gracefully
Date: Mon, 17 Dec 2007 16:59:38 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712171649420.9446@racer.site> (raw)
In-Reply-To: <9CC305E7-3325-4D17-A43E-0A2072F52084@ai.rug.nl>
Since commit 376ccb8cbb453343998e734d8a1ce79f57a4e092, unchanged
SHA-1s are no longer mapped via $REWRITTEN. But the updating
phase was not prepared for the old head not being rewritten.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
On Mon, 17 Dec 2007, Pieter de Bie wrote:
> Ok, but what about the error in the rebase?
>
> On Dec 14, 2007, at 2:21 AM, Pieter de Bie wrote:
> > Tirana:~/git pieter$ time git rebase -p -i HEAD~100
> > cat:
> > /Users/pieter/git/.git/.dotest-merge/rewritten/1e8df762b38e01685f3aa3613e2d61f73346fcbe:
> > No such file or directory
This buglet was not caught earlier, probably because a
non-rewriting rebase is not really interesting ;-)
git-rebase--interactive.sh | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index f83e00f..cd7e43f 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -322,7 +322,12 @@ do_next () {
test -f "$DOTEST"/current-commit &&
current_commit=$(cat "$DOTEST"/current-commit) &&
git rev-parse HEAD > "$REWRITTEN"/$current_commit
- NEWHEAD=$(cat "$REWRITTEN"/$OLDHEAD)
+ if test -f "$REWRITTEN"/$OLDHEAD
+ then
+ NEWHEAD=$(cat "$REWRITTEN"/$OLDHEAD)
+ else
+ NEWHEAD=$OLDHEAD
+ fi
else
NEWHEAD=$(git rev-parse HEAD)
fi &&
--
1.5.4.rc0.59.g1d10d
next prev parent reply other threads:[~2007-12-17 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 1:21 [BUG?] git rebase -i Pieter de Bie
2007-12-14 7:30 ` Johannes Sixt
2007-12-17 16:04 ` Pieter de Bie
2007-12-17 16:59 ` Johannes Schindelin [this message]
2007-12-17 20:23 ` [PATCH] rebase -p -i: handle "no changes" gracefully Junio C Hamano
2007-12-17 21:01 ` [PATCH w/ test] " Johannes Schindelin
2007-12-18 20:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712171649420.9446@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=pdebie@ai.rug.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).