From: Andy Dougherty <doughera@lafayette.edu>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Minor portability patch to git-submodule
Date: Tue, 18 Dec 2007 08:35:53 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0712180734520.28219@fractal.phys.lafayette.edu> (raw)
In-Reply-To: <Pine.LNX.4.64.0712172253150.9446@racer.site>
On Mon, 17 Dec 2007, Johannes Schindelin wrote:
> On Mon, 17 Dec 2007, Andy Dougherty wrote:
>
> > - git ls-files --stage -- "$@" | grep -e '^160000 ' |
> > + git ls-files --stage -- "$@" | egrep -e '^160000 ' |
>
> Nack. egrep is not available on all platforms. But then I have to wonder
> why not saying "grep '^160000 '" instead?
Your last suggestion is easily and obviously better -- I'll assume you
don't need an explicit patch and can just hand-edit mine. Still, I'd have
thought egrep was fine. As far as I recall, it goes back to v7 Unix. Or
are there non-unix systems at issue (perhaps cygwin variants or something)
that have grep but not egrep?
Anyway, thanks.
--
Andy Dougherty doughera@lafayette.edu
next prev parent reply other threads:[~2007-12-18 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 21:41 [PATCH] Minor portability patch to git-submodule Andy Dougherty
2007-12-17 22:54 ` Johannes Schindelin
2007-12-18 13:35 ` Andy Dougherty [this message]
2007-12-18 14:01 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712180734520.28219@fractal.phys.lafayette.edu \
--to=doughera@lafayette.edu \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).