git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Jörg Sommer" <joerg@alea.gnuu.de>
Cc: git@vger.kernel.org
Subject: Re: git-stash: RFC: Adopt the default behavior to other commands
Date: Tue, 18 Dec 2007 22:13:54 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0712182211510.23902@racer.site> (raw)
In-Reply-To: <20071218154211.GB12549@alea.gnuu.de>

Hi,

[please do not cull me from the Cc list, should you reply to this]

On Tue, 18 Dec 2007, J?rg Sommer wrote:

> Junio C Hamano schrieb am Mon 17. Dec, 16:31 (-0800):
> > Benoit Sigoure <tsuna@lrde.epita.fr> writes:
> > 
> > >> Benoit Sigoure <tsuna@lrde.epita.fr> writes:
> > >>
> > >>> ...  The current behavior of git stash is very
> > >>> dangerous ...
> > > ...
> > >> This is a plain FUD, isn't it?  The first Oops should not happen 
> > >> these days.
> > 
> > But the original point by Sebastian hasn't been answered.  He wanted 
> > to make the command list the stash without arguments.
> > 
> > This was discussed already in the early days of stash and there indeed 
> > was a suggestion to do so (I think I sided with that), but the users 
> > did not want it.  IIRC, the argument went like: "when I say 'stash', 
> > that is because I want a quick and immediate way to stash, and I do 
> > not want a list.  If I do not have to have a quick way, I would create 
> > a temporary commit on the current branch, or switch to a temporary 
> > branch and commit there."
> 
> When it should go quick why don't use an alias. git stash can print the 
> list and everyone who wants a quick stash can create an alias for this.
> 
> I vote for stash print the list, because I dropped in the pitfall.

And in a fresh clone, this list is empty, showing nothing at all.  Leading 
the other half of the users to believe that the stash succeeded.

If stashing as the default operation of stash is ill-advised, showing the 
list is even more so.

Ciao,
Dscho

  reply	other threads:[~2007-12-18 22:14 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17 11:03 git-stash: RFC: Adopt the default behavior to other commands Sebastian Harl
2007-12-17 22:32 ` Benoit Sigoure
2007-12-17 23:00   ` Junio C Hamano
2007-12-17 23:32     ` Benoit Sigoure
2007-12-18  0:31       ` Junio C Hamano
2007-12-18 10:59         ` Sebastian Harl
2007-12-18 12:33           ` Johannes Schindelin
2007-12-18 14:22             ` Andreas Ericsson
2007-12-18 14:47               ` Johannes Schindelin
2007-12-18 15:00                 ` Andreas Ericsson
2007-12-18 15:15                   ` Johannes Schindelin
2007-12-18 15:28                     ` Andreas Ericsson
2007-12-18 15:40                       ` Jakub Narebski
2007-12-18 16:06                         ` Andreas Ericsson
2007-12-18 16:11                           ` Johannes Schindelin
2007-12-18 17:40                             ` Sergei Organov
2007-12-18 18:03                               ` Johannes Schindelin
2007-12-18 23:31                                 ` Martin Langhoff
2007-12-18 15:28               ` Wincent Colaiuta
2007-12-18 15:42         ` Jörg Sommer
2007-12-18 22:13           ` Johannes Schindelin [this message]
2007-12-18 22:22           ` Junio C Hamano
2007-12-20 21:40             ` しらいしななこ
2007-12-20 22:31               ` Junio C Hamano
2007-12-21  7:59                 ` Wincent Colaiuta
2007-12-21  8:40                 ` しらいしななこ
2007-12-18 23:32           ` André Goddard Rosa
2007-12-18 23:41           ` Martin Langhoff
2007-12-19  7:33             ` Wincent Colaiuta
2007-12-19  7:46               ` Martin Langhoff
2007-12-19  8:29                 ` Andreas Ericsson
2007-12-19 12:01                 ` Johannes Schindelin
2007-12-19 12:07                   ` Wincent Colaiuta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0712182211510.23902@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=joerg@alea.gnuu.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).