From: malc <av1474@comtv.ru>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Alexandre Julliard <julliard@winehq.org>
Subject: Re: [PATCH] Change octal literals to be XEmacs friendly
Date: Fri, 23 Jan 2009 22:53:31 +0300 (MSK) [thread overview]
Message-ID: <Pine.LNX.4.64.0901232158290.2186@linmac.oyster.ru> (raw)
In-Reply-To: <7vbpty1m1r.fsf@gitster.siamese.dyndns.org>
On Fri, 23 Jan 2009, Junio C Hamano wrote:
> malc@pulsesoft.com writes:
>
>> case uses eql and (eql ?\001 1) evaluates to nil under XEmacs
>> (probably because some internal type of ?\001 is char)
>
> And I presume the new way to spell is compatible with non XEmacs emacs?
> It may be obvious to you, but please spell it out. Parenthesized
> "probably" does not help building the confidence in the patch either.
Fair enough.
XEmacs:
(type-of ?\1) yields character
FSF Emacs:
(type-of ?\1) yields integer
>
>> Signed-off-by: Vassili Karpov <av1474@comtv.ru>
>
> How are the (nameless) author of the patch malc@pulsesoft.com and Vassili
> Karpov, the person who signed off, related?
Both are my e-mail address used in ~/.gitconfig and ~/.emacs (and used
by GNUS which was used to post the message via gmane's nntp interface)
respectively.
> Next time, please spend a few minutes to see if there are active
> developers who are familiar in the area you are touching, and Cc your
> patch to ask their input.
>
> git blame -L562,+29 contrib/emacs/git.el
>
Okay.
> tells me that most of this came from 40f162b (git.el: Display file types
> and type changes., 2008-01-06) by Alexandre, so I am Cc'ing him.
>
[..snip..]
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2009-01-23 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 17:02 [PATCH] Change octal literals to be XEmacs friendly malc
2009-01-23 8:09 ` Junio C Hamano
2009-01-23 19:53 ` malc [this message]
2009-01-23 20:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0901232158290.2186@linmac.oyster.ru \
--to=av1474@comtv.ru \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=julliard@winehq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).