git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow curl to rewind the read buffers
Date: Wed, 1 Apr 2009 19:46:41 +0300 (EEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0904011943560.5901@localhost.localdomain> (raw)
In-Reply-To: <7vbprg1h3m.fsf@gitster.siamese.dyndns.org>

On Wed, 1 Apr 2009, Junio C Hamano wrote:

> It may be obvious to people proficient in cURL, but I had to guess that
> you perhaps meant to say "when using multi-pass authentication methods,
> cURL library may need to rewind the read buffers (depending on what is fed
> by the server), and in order to allow the library to do so, we need to
> tell it how by providing the way to manipulate the buffers we supply with
> these IOCTL callbacks."
> 
> Do I understand you correctly?

Yeah, that's exactly correct.

> My point is that the your two-line statement of fact (with a bit more
> explanation of the fact that follows) was clear but it was unclear to me
> how that fact translates to the need of what the patch does.  We would
> want the commit log message to be helpful to people who look at the code 6
> months down the line and wonder why these lines were added.

The original commit comment was a bit vague in retrospect, yes. I'll reply 
with an updated version soon.

Thanks!

// Martin

  reply	other threads:[~2009-04-01 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01 15:10 [PATCH] Allow curl to rewind the read buffers Martin Storsjö
2009-04-01 16:19 ` Junio C Hamano
2009-04-01 16:46   ` Martin Storsjö [this message]
2009-04-01 16:48   ` Martin Storsjö
2009-04-02  7:03     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0904011943560.5901@localhost.localdomain \
    --to=martin@martin.st \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).