git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Unknown <borg@uu3.net>
To: git@vger.kernel.org
Subject: [commit 4ecbc178704] Incosistency?
Date: Tue, 14 Jul 2009 23:41:40 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0907142335210.31779@cube> (raw)

commit 4ecbc178704ca6c1027a38483e98f5fe493b1322
Author: Jeff King <peff@peff.net>
Date:   Thu Jul 9 02:37:35 2009 -0400

bla bla.. some strange SUDO fix (who the hell uses git that way?)
I dont like it.. git-add in libexecdir was good!

diff --git a/Makefile b/Makefile
index 78cc113..311ce7d 100644
--- a/Makefile
+++ b/Makefile
@@ -1641,15 +1641,15 @@ ifneq (,$X)
  endif
         bindir=$$(cd '$(DESTDIR_SQ)$(bindir_SQ)' && pwd) && \
         execdir=$$(cd '$(DESTDIR_SQ)$(gitexec_instdir_SQ)' && pwd) && \
-       { $(RM) "$$execdir/git-add$X" && \
+       { $(RM) "$$execdir/git$X" && \
                 test -z "$(NO_CROSS_DIRECTORY_HARDLINKS)" && \
-               ln "$$bindir/git$X" "$$execdir/git-add$X" 2>/dev/null || \
-               cp "$$bindir/git$X" "$$execdir/git-add$X"; } && \
-       { for p in $(filter-out git-add$X,$(BUILT_INS)); do \
+               ln "$$bindir/git$X" "$$execdir/git$X" 2>/dev/null || \
+               cp "$$bindir/git$X" "$$execdir/git$X"; } && \
+       { for p in $(BUILT_INS); do \
                 $(RM) "$$execdir/$$p" && \
-               ln "$$execdir/git-add$X" "$$execdir/$$p" 2>/dev/null || \
-               ln -s "git-add$X" "$$execdir/$$p" 2>/dev/null || \
-               cp "$$execdir/git-add$X" "$$execdir/$$p" || exit; \
+               ln "$$execdir/git$X" "$$execdir/$$p" 2>/dev/null || \
+               ln -s "git$X" "$$execdir/$$p" 2>/dev/null || \
+               cp "$$execdir/git$X" "$$execdir/$$p" || exit; \
           done; } && \
         ./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"

Isnt check_bindir is broken now?
git-add is no more..

             reply	other threads:[~2009-07-14 21:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14 21:41 Unknown [this message]
2009-07-14 21:48 ` [commit 4ecbc178704] Incosistency? Jeff King
2009-07-14 22:30   ` Johannes Schindelin
2009-07-15  8:32   ` Unknown
2009-07-15  9:42     ` Jeff King
2009-07-17 17:42       ` Unknown
2009-07-14 22:42 ` Thomas Adam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0907142335210.31779@cube \
    --to=borg@uu3.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).