Re: [PATCH 1/4] refspec: trivial cleanup

[Jeff King <peff@peff.net>]

On Tue, Dec 01, 2020 at 05:25:53PM -0600, Felipe Contreras wrote:

> > I know your question was rhetorical, but a good reason not to do so in
> > general is that the existing pattern reveals some intent. E.g., it
> > sometimes is the case that with the _current_ code we can return early
> > from a function or loop, but that is not inherent to what the code is
> > doing, and the early return or continue makes it harder to understand
> > that.
> 
> Yes, but even in those cases it arguably helps readability.
> 
> Anyway, I prefer to argue on the tangible rather than hypotheticals
> because the hypotheticals are infinite.
>
> In this particular case there's no particular reason to just continue
> if there's no prefix.

Right, which I already agreed with.

I hesitated on responding at all, because you and I have not had a good
history of agreeing on commit messages. But my comment was primarily for
other readers on the list. I do not want people blindly applying a rule
like "less indentation is good" without thinking about the code overall
(I don't know whether you thought about it or not, but it was not
apparent from your commit message).

-Peff