From: Denton Liu <liu.denton@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Emily Shaffer <emilyshaffer@google.com>
Subject: Re: [PATCH] Add project-wide .vimrc configuration
Date: Tue, 8 Dec 2020 17:32:11 -0800 [thread overview]
Message-ID: <X9ApG0jUxJrPDK9d@generichostname> (raw)
In-Reply-To: <20201209002619.25468-1-felipe.contreras@gmail.com>
Hi Felipe,
On Tue, Dec 08, 2020 at 06:26:19PM -0600, Felipe Contreras wrote:
> It's not efficient that everyone must set specific configurations in all
> their ~/.vimrc files; we can have a project-wide .vimrc that everyone
> can use.
>
> By default it's ignored, you need the following in your ~/.vimrc
>
> set exrc
> set secure
>
> Then the project-wide configuration is loaded, which sets the correct
> filetype for the documentation and tests, and also the default
> indentation of c, sh, and asciidoc files.
>
> If you have the shareness syntax file it will be used for the tests, but
s/shareness/sharness/
> if not the sh syntax will still be used.
>
> These default configurations can be overriden in the typical way (by
> adding the corresponding file in ~/.vim/after/ftplugin).
>
> We could add the vim modelines at the bottom of every file, like other
> projects do, but this seems more sensible.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> .vimrc | 9 +++++++++
> 1 file changed, 9 insertions(+)
> create mode 100644 .vimrc
>
> diff --git a/.vimrc b/.vimrc
> new file mode 100644
> index 0000000000..d250ab26e0
> --- /dev/null
> +++ b/.vimrc
> @@ -0,0 +1,9 @@
> +augroup git
> + au!
> + au BufRead,BufNewFile */t/*.sh set ft=sharness.sh
> + au BufRead,BufNewFile */Documentation/*.txt set ft=asciidoc
> +
> + au FileType c setl noet ts=8 sw=0 cino=(s,:0,l1,t0
> + au FileType sh setl noet ts=8 sw=0
> + au FileType asciidoc setl noet ts=8 sw=0 autoindent
> +augroup END
A couple of nits. We should tab-indent this file since the rest of the
project uses tabs everywhere. Also, perhaps use the full name for the
option names so that it's immediately obvious what each setting does?
Aside from that, the settings themselves are sensible and I'm for this
patch.
-Denton
> --
> 2.29.2
>
next prev parent reply other threads:[~2020-12-09 1:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 0:26 [PATCH] Add project-wide .vimrc configuration Felipe Contreras
2020-12-09 1:08 ` Junio C Hamano
2020-12-09 2:32 ` Felipe Contreras
2020-12-09 1:18 ` Aaron Schrab
2020-12-09 3:15 ` Junio C Hamano
2020-12-09 6:28 ` Felipe Contreras
2020-12-09 1:32 ` Denton Liu [this message]
2020-12-09 6:20 ` Felipe Contreras
2020-12-09 2:23 ` brian m. carlson
2020-12-09 6:36 ` Felipe Contreras
2020-12-09 6:54 ` Junio C Hamano
2020-12-09 7:16 ` Felipe Contreras
2020-12-09 8:13 ` Junio C Hamano
2020-12-09 8:52 ` Felipe Contreras
2020-12-09 16:18 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9ApG0jUxJrPDK9d@generichostname \
--to=liu.denton@gmail.com \
--cc=emilyshaffer@google.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).