Git development
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Michael J Gruber <git@grubix.eu>, git@vger.kernel.org
Subject: Re: [PATCH] notes: avoid empty line in template
Date: Wed, 16 Nov 2022 14:57:56 -0500	[thread overview]
Message-ID: <Y3VAxO+EQVXVu92z@nand.local> (raw)
In-Reply-To: <Y3Uxh25Gh5fPQrMq@coredump.intra.peff.net>

On Wed, Nov 16, 2022 at 01:52:55PM -0500, Jeff King wrote:
> > diff --git a/builtin/notes.c b/builtin/notes.c
> > index be51f69225..80d9dfd25c 100644
> > --- a/builtin/notes.c
> > +++ b/builtin/notes.c
> > @@ -181,7 +181,7 @@ static void prepare_note_data(const struct object_id *object, struct note_data *
> >  		strbuf_addch(&buf, '\n');
> >  		strbuf_add_commented_lines(&buf, "\n", strlen("\n"));
> >  		strbuf_add_commented_lines(&buf, _(note_template), strlen(_(note_template)));
> > -		strbuf_addch(&buf, '\n');
> > +		strbuf_add_commented_lines(&buf, "\n", strlen("\n"));
>
> And the patch looks obviously good. The irony is the version two lines
> above which does it correctly. ;)

Thanks, both. ;-).

Thanks,
Taylor

  reply	other threads:[~2022-11-16 19:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 15:56 [PATCH] notes: avoid empty line in template Michael J Gruber
2022-11-16 18:52 ` Jeff King
2022-11-16 19:57   ` Taylor Blau [this message]
2022-11-17  9:48 ` Ævar Arnfjörð Bjarmason
2022-11-17 10:13   ` Michael J Gruber
2022-11-17 15:12     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3VAxO+EQVXVu92z@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@grubix.eu \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox