From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D205C54EBE for ; Tue, 17 Jan 2023 03:04:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234405AbjAQDE1 (ORCPT ); Mon, 16 Jan 2023 22:04:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234606AbjAQDE0 (ORCPT ); Mon, 16 Jan 2023 22:04:26 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 691752681 for ; Mon, 16 Jan 2023 19:04:25 -0800 (PST) Received: (qmail 19213 invoked by uid 109); 17 Jan 2023 03:04:25 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 17 Jan 2023 03:04:25 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 3849 invoked by uid 111); 17 Jan 2023 03:04:27 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 16 Jan 2023 22:04:27 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 16 Jan 2023 22:04:24 -0500 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org, Ramsay Jones Subject: Re: [PATCH 1/3] http-push: prefer CURLOPT_UPLOAD to CURLOPT_PUT Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jan 16, 2023 at 10:03:33PM -0500, Jeff King wrote: > The two options do exactly the same thing, but the latter has been > deprecated and in recent versions of curl may produce a compiler > warning. Since the UPLOAD form is available everywhere (it was > introduced in the year 2000 by curl 7.1), we can just switch to it. > > Signed-off-by: Jeff King Whoops, this was supposed to be part of v2, but I accidentally sent it in reply to the wrong part of the thread. Please ignore, and I'll resend in the right spot. -Peff