From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDBEDC433DB for ; Tue, 19 Jan 2021 22:22:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 960B422E01 for ; Tue, 19 Jan 2021 22:22:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729681AbhASWWJ (ORCPT ); Tue, 19 Jan 2021 17:22:09 -0500 Received: from cloud.peff.net ([104.130.231.41]:60330 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbhASWQX (ORCPT ); Tue, 19 Jan 2021 17:16:23 -0500 Received: (qmail 15030 invoked by uid 109); 19 Jan 2021 22:15:31 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 19 Jan 2021 22:15:31 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12979 invoked by uid 111); 19 Jan 2021 22:15:32 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 19 Jan 2021 17:15:32 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 19 Jan 2021 17:15:30 -0500 From: Jeff King To: Taylor Blau Cc: Jacob Vosmaer , Git Mailing List Subject: Re: [PATCH 1/1] ls-refs.c: minimize number of refs visited Message-ID: References: <20210119144251.27924-1-jacob@gitlab.com> <20210119144251.27924-2-jacob@gitlab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jan 19, 2021 at 04:59:18PM -0500, Jeff King wrote: > > > What does "delimited by /" mean? > > > > Ah, I just meant that it looks for the longest common prefix where it > > will only split at '/' characters. But, that's not right at all: > > find_longest_prefixes_1() will happily split anywhere there is a > > difference. > > Right. We thought in early revisions of the ref-filter work that we > might have to split on path components, but it turns out that the > underlying ref code is happy to take arbitrary prefixes. And it's that > code which defines our strategy; Even if the ls-refs code wanted to > allow only full path components, it should be using the limiting from > for_each_ref_in() only as an optimization, and applying its own > filtering to the output. Having now looked carefully at the ls-refs code, it's a pure prefix-match, too. So I think we _could_ rely on for_each_fullref_in() returning us the correct full results, and not checking it further in send_ref(). But I kind of like keeping it there as an extra check (and one which could in theory grow more logic later). -Peff