From: Jonathan Nieder <jrnieder@gmail.com>
To: "René Scharfe." <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] block-sha1: drop trailing semicolon from macro definition
Date: Mon, 15 Mar 2021 16:07:23 -0700 [thread overview]
Message-ID: <YE/oq5dPDB6PvD22@google.com> (raw)
In-Reply-To: <f8122736-e729-5d35-e1e1-78a213816d4a@web.de>
René Scharfe. wrote:
> 23119ffb4e (block-sha1: put expanded macro parameters in parentheses,
> 2012-07-22) added a trailing semicolon to the definition of SHA_MIX
> without explanation. It doesn't matter with the current code, but make
> sure to avoid potential surprises by removing it again.
>
> This allows the macro to be used almost like a function: Users can
> combine it with operators of their choice, but still must not pass an
> expression with side-effects as a parameter, as it would be evaluated
> multiple times.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> block-sha1/sha1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Yes, it was just a typo.
prev parent reply other threads:[~2021-03-15 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 16:17 [PATCH] block-sha1: drop trailing semicolon from macro definition René Scharfe.
2021-03-15 23:07 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YE/oq5dPDB6PvD22@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).