From: Denton Liu <liu.denton@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "David Aguilar" <davvid@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH v4] contrib/completion: fix zsh completion regression from 59d85a2a05
Date: Wed, 2 Jun 2021 00:13:30 -0700 [thread overview]
Message-ID: <YLcvmrwT/ZuMts2C@generichostname> (raw)
In-Reply-To: <60b6c57c3cac1_4044208f@natae.notmuch>
On Tue, Jun 01, 2021 at 06:40:44PM -0500, Felipe Contreras wrote:
> I have not tested this particular version, but I have tested similar
> changes, and this should work:
>
> Acked-by: Felipe Contreras <felipe.contreras@gmail.com>
FWIW, since I was the one who introduced the bug,
Acked-by: Denton Liu <liu.denton@gmail.com>
Thanks for your help, David and Felipe.
prev parent reply other threads:[~2021-06-02 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 20:52 [PATCH v4] contrib/completion: fix zsh completion regression from 59d85a2a05 David Aguilar
2021-06-01 23:40 ` Felipe Contreras
2021-06-02 7:13 ` Denton Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLcvmrwT/ZuMts2C@generichostname \
--to=liu.denton@gmail.com \
--cc=davvid@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).