From: Taylor Blau <me@ttaylorr.com>
To: Chris Torek <chris.torek@gmail.com>
Cc: "Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Emily Shaffer" <emilyshaffer@google.com>,
"Git List" <git@vger.kernel.org>,
"Josh Steadmon" <steadmon@google.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH] trace2: log progress time and throughput
Date: Tue, 22 Jun 2021 23:42:54 -0400 [thread overview]
Message-ID: <YNKtvj4z2dwSUvOS@nand.local> (raw)
In-Reply-To: <CAPx1Gve_KqzQHanDDTSJ_2QywzNybq-J3wkG8xBC_DUhwVB5Fg@mail.gmail.com>
On Tue, Jun 22, 2021 at 08:29:35PM -0700, Chris Torek wrote:
> On Tue, Jun 22, 2021 at 7:56 PM Taylor Blau <me@ttaylorr.com> wrote:
> >... I was going to comment on the fact that "(*p_progress)->total" could
> > be written simply as "*p_progress->total", but I'm (a) not sure that I
> > actually prefer the latter to the former, and (b) I find that kind of
> > style comment generally useless.
>
> Also, it can't. :-) The binding order is wrong; *p_progress->total binds as
> *(p_progress->total), and `p_progress` has to be followed first, so this
> just doesn't work.
Ack, serves me right for starting a discussion based on operator
precedence. Yes, you're right, I was mistaken and forgot that -> binds
with highest precedence in C (above *, which is why this doesn't work).
In any case, my confusion is probably a good reason to avoid this
entirely by manipulating a variable which stores *p_progress.
Thanks,
Taylor
prev parent reply other threads:[~2021-06-23 3:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 21:44 [PATCH] trace2: log progress time and throughput Emily Shaffer
2020-05-12 22:14 ` Junio C Hamano
2020-05-13 19:46 ` Josh Steadmon
2020-05-15 10:59 ` Derrick Stolee
2020-05-15 15:27 ` Junio C Hamano
2020-05-15 16:09 ` Junio C Hamano
2020-05-15 16:49 ` Derrick Stolee
2020-05-15 17:00 ` Junio C Hamano
2020-05-15 19:37 ` Jeff Hostetler
2020-05-15 19:44 ` Jeff Hostetler
2021-06-21 1:24 ` Ævar Arnfjörð Bjarmason
2021-06-21 13:55 ` Elijah Newren
2021-06-21 14:51 ` Ævar Arnfjörð Bjarmason
2021-06-21 20:28 ` Elijah Newren
2021-06-23 2:55 ` Taylor Blau
2021-06-23 3:29 ` Chris Torek
2021-06-23 3:42 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNKtvj4z2dwSUvOS@nand.local \
--to=me@ttaylorr.com \
--cc=avarab@gmail.com \
--cc=chris.torek@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=steadmon@google.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).