Git development
 help / color / mirror / Atom feed
From: Ben Boeckel <mathstuf@gmail.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
	"Jeff Hostetler" <jeffhost@microsoft.com>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Taylor Blau" <me@ttaylorr.com>
Subject: Re: [PATCH 0/1] Improve automatic setup of tracking for new branches
Date: Fri, 30 Jul 2021 13:45:41 -0400	[thread overview]
Message-ID: <YQQ6xSlX+0LvBBWX@erythro.dev.benboeckel.internal> (raw)
In-Reply-To: <7b50ebc6-7b28-412d-b124-9bd54750c922@gmail.com>

On Fri, Jul 30, 2021 at 12:01:36 -0400, Philippe Blain wrote:
> Hi again,
> 
> Le 2021-07-30 à 09:57, Ben Boeckel a écrit :
> > On Fri, Jul 30, 2021 at 09:35:39 -0400, Philippe Blain wrote:
> >> Le 2021-07-28 à 22:01, Ben Boeckel a écrit :
> >>
> >> Small nit: usually when sending a second version of a patch, you would use
> >> the '-v2' argument to 'git format-patch' so that the patch and cover letter
> >> is prefixed [PATCH v2].
> > 
> > Yes, I realized that I had forgotten the `--reroll-count=` argument when
> > making this patch (I suppose a way to store the Cc list for a topic
> > somewhere would be nice so I didn't lean so heavily on shell history
> > would help this).
> 
> There is 'format.cc', but it's not branch-specific, so you would have to
> use one worktree per branch with extension.worktreeConfig...

I suppose a `branch.<name>.cc` configuration might be in order :) .
Though at that point, `branch.<name>.rerollCount` and
`branch.<name>.sendEmailTo` also make sense…

More brainstorming below too.

> > FWIW, my main gripe with the email-based workflow is the lack of
> > coordinated metadata (LWN has numerous comments by me about my views if
> > you're curious, but I should really formalize them into blog posts). But
> > when in Rome :) .
> 
> I agree. I almost always use Gitgitgadget [1], which keeps track of the CC list for
> me, of updating the re-roll count, of adding the in-reply-to header such that subsequent
> versions of the series are sent as a response to the cover letter of the previous version,
> generating a range-diff against the previous version,
> commenting on the PR when the series is mentioned in "What's cooking", etc.

That's nifty. I guess since I started here, things are a bit messy for
this patch though?

> Some things it does not support are: sending a patch as a response to some random
> mail on the list, which is sometimes useful, reading the commit notes to generate
> in-patch commentaries [2], customizing the diff generated by 'format-patch'.
> Other things are listed at [3].
> 
> Recently I've even been using only the terminal with Gitgitgadget:
> I use 'git branch --edit-description'
> to write my cover letter, and then use the 'gh' GitHub CLI to open my PR:

I think having `branch.<name>.coverLetter` and/or
`branch.coverLetterDirectory` (defaulting to reading `<name>` or
`<name>.txt`) to store the cover letter contents would be nice. I know
I've blown away enough `0000-*.patch` edits with an ill-timed `git
format-patch` before…

Forges could use this to hook in with their push options[1] through
their wrappers or other tools.

--Ben

[1]https://docs.gitlab.com/ee/user/project/push_options.html#push-options-for-merge-requests

  reply	other threads:[~2021-07-30 17:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 13:50 [PATCH 0/1] Improve automatic setup of tracking for new branches Ben Boeckel
2021-07-28 13:50 ` [PATCH 1/1] config: support setting up a remote tracking branch upon creation Ben Boeckel
2021-07-28 17:48   ` Junio C Hamano
2021-07-28 18:26     ` Ben Boeckel
2021-07-28 18:39       ` Junio C Hamano
2021-07-29  2:01 ` [PATCH 0/1] Improve automatic setup of tracking for new branches Ben Boeckel
2021-07-29  2:01   ` [PATCH 1/1] config: support a default remote tracking setup upon branch creation Ben Boeckel
2021-07-30 13:35     ` Philippe Blain
2021-07-30 14:07       ` Ben Boeckel
2021-07-30 17:32       ` Junio C Hamano
2021-08-02 13:02     ` Ævar Arnfjörð Bjarmason
2021-08-02 13:16       ` Ben Boeckel
2021-08-02 15:20         ` Ævar Arnfjörð Bjarmason
2021-07-30  1:04   ` [PATCH 0/1] Improve automatic setup of tracking for new branches Junio C Hamano
2021-07-30  1:33     ` Ben Boeckel
2021-07-30 13:35   ` Philippe Blain
2021-07-30 13:57     ` Ben Boeckel
2021-07-30 16:01       ` Philippe Blain
2021-07-30 17:45         ` Ben Boeckel [this message]
2021-08-02 21:17         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQQ6xSlX+0LvBBWX@erythro.dev.benboeckel.internal \
    --to=mathstuf@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    --cc=levraiphilippeblain@gmail.com \
    --cc=martin.agren@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox