From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] ls-remote: set packet_trace_identity(<name>)
Date: Mon, 23 Aug 2021 12:08:00 -0400 [thread overview]
Message-ID: <YSPH4PoRG78Ybv0J@coredump.intra.peff.net> (raw)
In-Reply-To: <patch-1.1-5d3a2b96500-20210823T131533Z-avarab@gmail.com>
On Mon, Aug 23, 2021 at 03:17:49PM +0200, Ævar Arnfjörð Bjarmason wrote:
> Set packet_trace_identity() for ls-remote. This replaces the generic
> "git" identity in GIT_TRACE_PACKET=<file> traces to "ls-remote", e.g.:
>
> [...] packet: upload-pack> version 2
> [...] packet: upload-pack> agent=git/2.32.0-dev
> [...] packet: ls-remote< version 2
> [...] packet: ls-remote< agent=git/2.32.0-dev
>
> Where in an "git ls-remote file://<path>" dialog ">" is the sender (or
> "to the server") and "<" is the recipient (or "received by the
> client").
Thanks, this looks like an obvious improvement. I'm a little surprised
it wasn't there already, but I guess I just missed it way back in
bbc30f9963 (add packet tracing debug code, 2011-02-24).
-Peff
prev parent reply other threads:[~2021-08-23 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 13:17 [PATCH] ls-remote: set packet_trace_identity(<name>) Ævar Arnfjörð Bjarmason
2021-08-23 16:08 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSPH4PoRG78Ybv0J@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).