From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH] clone: handle unborn branch in bare repos
Date: Mon, 20 Sep 2021 16:28:06 -0400 [thread overview]
Message-ID: <YUju1gmT1nDh1PLv@nand.local> (raw)
In-Reply-To: <YUjbKt0Hw0ieHcaN@coredump.intra.peff.net>
On Mon, Sep 20, 2021 at 03:04:10PM -0400, Jeff King wrote:
> When cloning a repository with an unborn HEAD, we'll set the local HEAD
> to match it only if the local repository is non-bare. This is
> inconsistent with all other combinations:
>
> remote HEAD | local repo | local HEAD
> -----------------------------------------------
> points to commit | non-bare | same as remote
> points to commit | bare | same as remote
> unborn | non-bare | same as remote
> unborn | bare | local default
>
> So I don't think this is some clever or subtle behavior, but just a bug
> in 4f37d45706 (clone: respect remote unborn HEAD, 2021-02-05). And it's
> easy to see how we ended up there. Before that commit, the code to set
> up the HEAD for an empty repo was guarded by "if (!option_bare)". That's
> because the only thing it did was call install_branch_config(), and we
> don't want to do so for a bare repository (unborn HEAD or not).
Readding this and 4f37d45706, I tend to agree. Thanks for a
straightforward patch, fix, and test :-).
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Thanks,
Taylor
prev parent reply other threads:[~2021-09-21 1:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 19:04 [PATCH] clone: handle unborn branch in bare repos Jeff King
2021-09-20 19:50 ` Jonathan Tan
2021-09-20 20:28 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUju1gmT1nDh1PLv@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).