git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Jeff King <peff@peff.net>, Taylor Blau <me@ttaylorr.com>,
	"Robin H . Johnson" <robbat2@gentoo.org>
Subject: Re: [PATCH] bundle: remove ignored & undocumented "--verbose" flag
Date: Thu, 23 Sep 2021 13:38:34 -0400	[thread overview]
Message-ID: <YUy7mkaRCLKrMJBw@nand.local> (raw)
In-Reply-To: <patch-1.1-d61f4b28dfd-20210923T164636Z-avarab@gmail.com>

On Thu, Sep 23, 2021 at 06:48:22PM +0200, Ævar Arnfjörð Bjarmason wrote:
> In 73c3253d75e (bundle: framework for options before bundle file,
> 2019-11-10) the "git bundle" command was refactored to use
> parse_options(). In that refactoring it started understanding the
> "--verbose" flag before the subcommand, e.g.:
>
>     git bundle --verbose verify --quiet
>
> However, nothing ever did anything with this "verbose" variable, and
> the change wasn't documented. It appears to have been something that
> escaped the lab, and wasn't flagged by reviewers at the time. Let's
> just remove it.

Thanks; this looks good to me. We never use the `verbose` variable for
anything, and it isn't documented. So I agree that it can be removed.

Thanks for cleaning this up:

    Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks,
Taylor

      reply	other threads:[~2021-09-23 17:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 16:48 [PATCH] bundle: remove ignored & undocumented "--verbose" flag Ævar Arnfjörð Bjarmason
2021-09-23 17:38 ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUy7mkaRCLKrMJBw@nand.local \
    --to=me@ttaylorr.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=robbat2@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).