git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Oct 2021, #02; Wed, 6)
Date: Wed, 6 Oct 2021 23:55:12 -0400	[thread overview]
Message-ID: <YV5voCafN8dLff/R@nand.local> (raw)
In-Reply-To: <YV5aaD418SyZqS/1@coredump.intra.peff.net>

On Wed, Oct 06, 2021 at 10:24:40PM -0400, Jeff King wrote:
> On Wed, Oct 06, 2021 at 05:24:14PM -0700, Junio C Hamano wrote:
>
> > * tb/repack-write-midx (2021-10-01) 9 commits
> >   (merged to 'next' on 2021-10-06 at ccdd5aaf2a)
> >  + builtin/repack.c: pass `--refs-snapshot` when writing bitmaps
> >  + builtin/repack.c: make largest pack preferred
> >  + builtin/repack.c: support writing a MIDX while repacking
> >  + builtin/repack.c: extract showing progress to a variable
> >  + builtin/repack.c: rename variables that deal with non-kept packs
> >  + builtin/repack.c: keep track of existing packs unconditionally
> >  + midx: preliminary support for `--refs-snapshot`
> >  + builtin/multi-pack-index.c: support `--stdin-packs` mode
> >  + midx: expose `write_midx_file_only()` publicly
> >
> >  "git repack" has been taught to generate multi-pack reachability
> >  bitmaps.
> >
> >  Will merge to 'master'.
>
> Sorry not to catch this before it hit 'next', but there's a small leak
> in the test helper. This patch can go on top to fix it.

Thanks for taking a look and catching this. The fix you wrote looks
good to me. For what it's worth:

    Acked-by: Taylor Blau <me@ttaylorr.com>

Thanks,
Taylor

  parent reply	other threads:[~2021-10-07  3:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07  0:24 What's cooking in git.git (Oct 2021, #02; Wed, 6) Junio C Hamano
2021-10-07  2:01 ` ab/make-sparse-for-real Ævar Arnfjörð Bjarmason
2021-10-07  2:24 ` What's cooking in git.git (Oct 2021, #02; Wed, 6) Jeff King
2021-10-07  2:38   ` Jeff King
2021-10-07  4:07     ` Taylor Blau
2021-10-08  3:55       ` Jeff King
2021-10-08  7:51         ` Johannes Schindelin
2021-10-08 21:32           ` Jeff King
2021-10-20 12:27             ` Johannes Schindelin
2021-10-20 14:30               ` Taylor Blau
2021-10-20 14:47               ` Junio C Hamano
2021-10-20 16:13               ` Jeff King
2022-08-16  9:05                 ` Coverity, was " Johannes Schindelin
2022-08-17  0:57                   ` Jeff King
2022-08-19 11:22                     ` Johannes Schindelin
2021-10-07  7:42     ` Ævar Arnfjörð Bjarmason
2021-10-08  4:10       ` Jeff King
2021-10-08 20:03         ` Junio C Hamano
2021-10-08 20:19           ` Jeff King
2021-10-08 21:57             ` Junio C Hamano
2021-10-07  2:57   ` Ævar Arnfjörð Bjarmason
2021-10-07  4:15     ` Taylor Blau
2021-10-07  3:55   ` Taylor Blau [this message]
2021-10-07 18:02   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YV5voCafN8dLff/R@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).