git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <alexander.riesen@cetitec.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH 2/2] Fix "commit-msg" hook unexpectedly called for "git pull --no-verify"
Date: Thu, 28 Oct 2021 19:16:21 +0200	[thread overview]
Message-ID: <YXra5UgxtgVubJL/@pflmari> (raw)
In-Reply-To: <xmqqv91hrt2y.fsf@gitster.g>

Junio C Hamano, Thu, Oct 28, 2021 18:51:17 +0200:
> Alex Riesen <alexander.riesen@cetitec.com> writes:
> 
> > Subject: Re: [PATCH 2/2] Fix "commit-msg" hook unexpectedly called for "git pull --no-verify"
> 
> Perhaps
> 
>     Subject: [PATCH] pull: honor --no-verify and do not call the commit-msg hook
> 
> instead.

Looks fine from my side. Shall I resend?

> Looks quite straight-forward, especially that now this just mimicks
> how --[no-]verify-signatures is passed through.
> 
> Thanks, will queue.

Or did you queue it as is?

Regards,
Alex


  reply	other threads:[~2021-10-28 17:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 12:11 [PATCH] Fix "commit-msg" hook unexpectedly called for "git pull --no-verify" Alex Riesen
2021-10-26 21:16 ` Jeff King
2021-10-27  6:35   ` [PATCH v2] " Alex Riesen
2021-10-27  9:06     ` Jeff King
2021-10-27 12:09   ` [PATCH] " Alex Riesen
2021-10-27 12:19     ` Jeff King
2021-10-27 13:27       ` [PATCH] Remove negation from the merge option "--no-verify" Alex Riesen
2021-10-27 20:16         ` Junio C Hamano
2021-10-28  6:38           ` Alex Riesen
2021-10-28  8:04             ` [PATCH] Remove negation from the commit and " Alex Riesen
2021-10-28 13:57               ` Phillip Wood
2021-10-28 15:44                 ` Alex Riesen
2021-10-28 15:46                   ` [PATCH 2/2] Fix "commit-msg" hook unexpectedly called for "git pull --no-verify" Alex Riesen
2021-10-28 16:51                     ` Junio C Hamano
2021-10-28 17:16                       ` Alex Riesen [this message]
2021-10-28 19:25                         ` Junio C Hamano
2021-10-29  6:34                           ` Alex Riesen
2021-10-28 15:49                   ` [PATCH] Remove negation from the commit and merge option "--no-verify" Alex Riesen
2021-10-29 13:32                   ` Phillip Wood
2021-10-29 13:45                     ` [PATCH] Document positive variant of " Alex Riesen
2021-11-01 15:34                       ` Phillip Wood
2021-10-27 20:12   ` [PATCH] Fix "commit-msg" hook unexpectedly called for "git pull --no-verify" Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXra5UgxtgVubJL/@pflmari \
    --to=alexander.riesen@cetitec.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).