git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>, Birk Tjelmeland <git@birktj.no>,
	git@vger.kernel.org
Subject: Re: [PATCH] stash: show error message when lockfile is present
Date: Mon, 8 Nov 2021 12:56:10 -0500	[thread overview]
Message-ID: <YYlkumkOWotx6umn@nand.local> (raw)
In-Reply-To: <xmqqlf1zunqe.fsf@gitster.g>

On Sun, Nov 07, 2021 at 11:10:17PM -0800, Junio C Hamano wrote:
> I would think the "fix" should look more like this:
>
>  	read_cache_preload(NULL);
> 	if (refresh_and_write_cache(REFRESH_QUIET, 0, 0))
> - 		return -1;
> + 		return error(_("failed to refresh the index"));
>
> That is, tell the function that the caller will do the error
> reporting (i.e. "QUIET") and do so.

Thanks; this is a much better approach. It makes Birk's change much more
direct, and does not require plumbing a new parameter through many
function calls.

Doing something like this (with appropriate tests) would look good to
me.

Thanks,
Taylor

  reply	other threads:[~2021-11-08 17:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-07 21:30 [PATCH] stash: show error message when lockfile is present Birk Tjelmeland
2021-11-08  3:21 ` Taylor Blau
2021-11-08  4:15   ` Taylor Blau
2021-11-08  7:10   ` Junio C Hamano
2021-11-08 17:56     ` Taylor Blau [this message]
2021-11-08 19:05     ` Ævar Arnfjörð Bjarmason
2021-11-08 20:05       ` Junio C Hamano
2021-11-08 20:35         ` Birk Tjelmeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYlkumkOWotx6umn@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@birktj.no \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).