From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Han-Wen Nienhuys <hanwen@google.com>, git <git@vger.kernel.org>
Subject: Re: t5327 log expiry
Date: Tue, 21 Dec 2021 16:39:42 -0500 [thread overview]
Message-ID: <YcJJntHTRkPWEEpD@nand.local> (raw)
In-Reply-To: <xmqqa6gtptv2.fsf@gitster.g>
On Tue, Dec 21, 2021 at 12:48:17PM -0800, Junio C Hamano wrote:
> Han-Wen Nienhuys <hanwen@google.com> writes:
>
> > Hi Taylor,
> >
> > Your recent work on cruft packs breaks with reftable. I suggest the
> > following change
> >
> > - rm -fr .git/logs &&
> > + git reflog expire --all --expire=all &&
> >
> > to make the test independent of ref storage format.
>
> Thanks. I should have caught it when I read the patch.
And I should have never written it in the first place ;). I did a
find-and-replace throughout the series to replace one with the other.
I have some review from Stolee that I want to read through before
sending an updated version. I'm planning on looking at that when I get
back in the new year.
Thanks,
Taylor
prev parent reply other threads:[~2021-12-21 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 17:27 t5327 log expiry Han-Wen Nienhuys
2021-12-21 20:48 ` Junio C Hamano
2021-12-21 21:39 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcJJntHTRkPWEEpD@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).