* t5327 log expiry
@ 2021-12-21 17:27 Han-Wen Nienhuys
2021-12-21 20:48 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Han-Wen Nienhuys @ 2021-12-21 17:27 UTC (permalink / raw)
To: Taylor Blau, git
Hi Taylor,
Your recent work on cruft packs breaks with reftable. I suggest the
following change
- rm -fr .git/logs &&
+ git reflog expire --all --expire=all &&
to make the test independent of ref storage format.
--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: t5327 log expiry
2021-12-21 17:27 t5327 log expiry Han-Wen Nienhuys
@ 2021-12-21 20:48 ` Junio C Hamano
2021-12-21 21:39 ` Taylor Blau
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2021-12-21 20:48 UTC (permalink / raw)
To: Han-Wen Nienhuys; +Cc: Taylor Blau, git
Han-Wen Nienhuys <hanwen@google.com> writes:
> Hi Taylor,
>
> Your recent work on cruft packs breaks with reftable. I suggest the
> following change
>
> - rm -fr .git/logs &&
> + git reflog expire --all --expire=all &&
>
> to make the test independent of ref storage format.
Thanks. I should have caught it when I read the patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: t5327 log expiry
2021-12-21 20:48 ` Junio C Hamano
@ 2021-12-21 21:39 ` Taylor Blau
0 siblings, 0 replies; 3+ messages in thread
From: Taylor Blau @ 2021-12-21 21:39 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Han-Wen Nienhuys, git
On Tue, Dec 21, 2021 at 12:48:17PM -0800, Junio C Hamano wrote:
> Han-Wen Nienhuys <hanwen@google.com> writes:
>
> > Hi Taylor,
> >
> > Your recent work on cruft packs breaks with reftable. I suggest the
> > following change
> >
> > - rm -fr .git/logs &&
> > + git reflog expire --all --expire=all &&
> >
> > to make the test independent of ref storage format.
>
> Thanks. I should have caught it when I read the patch.
And I should have never written it in the first place ;). I did a
find-and-replace throughout the series to replace one with the other.
I have some review from Stolee that I want to read through before
sending an updated version. I'm planning on looking at that when I get
back in the new year.
Thanks,
Taylor
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-21 21:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-21 17:27 t5327 log expiry Han-Wen Nienhuys
2021-12-21 20:48 ` Junio C Hamano
2021-12-21 21:39 ` Taylor Blau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).