From: Todd Zullinger <tmz@pobox.com>
To: git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Petr Šplíchal" <psplicha@redhat.com>
Subject: [BUG] builtin/checkout.c:1098: should be able to skip past 'refs/heads/'
Date: Thu, 20 Jan 2022 11:51:37 -0500 [thread overview]
Message-ID: <YemTGQZ97vAPUPY0@pobox.com> (raw)
Hi,
A bug was filed in the Fedora/Red Hat bugzilla today for the
git 2.35.0 rc (rc1, but it's the same in rc2). Petr (Cc'd),
ran the following
git clone https://github.com/psss/fmf /tmp/fmf
cd /tmp/fmf
cp .git/refs/remotes/origin/HEAD .git/refs/heads/__DEFAULT__
git checkout -f __DEFAULT__
git checkout -f __DEFAULT__
The second git checkout call runs into the BUG() call added
in 9081a421a6 (checkout: fix "branch info" memory leaks,
2021-11-16):
BUG: builtin/checkout.c:1098: should be able to skip
past 'refs/heads/' in 'refs/remotes/origin/master'!
Aborted (core dumped)
This worked in 2.34.1, so it's new to 2.35.0. Should this
work or does the manual copy to setup a branch fall into a
new category of "don't do that"?
(It's novel to get a bug report from rc testing of a distro
build -- that doesn't happen often.)
--
Todd
next reply other threads:[~2022-01-20 16:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 16:51 Todd Zullinger [this message]
2022-01-20 17:04 ` [BUG] builtin/checkout.c:1098: should be able to skip past 'refs/heads/' Todd Zullinger
2022-01-20 21:26 ` [PATCH] checkout: fix BUG() case in 9081a421a6 Ævar Arnfjörð Bjarmason
2022-01-20 22:29 ` Junio C Hamano
2022-01-20 22:33 ` Junio C Hamano
2022-01-21 11:14 ` Ævar Arnfjörð Bjarmason
2022-01-21 14:29 ` Petr Šplíchal
2022-01-21 21:58 ` Todd Zullinger
2022-01-21 21:19 ` Junio C Hamano
2022-01-20 22:33 ` Todd Zullinger
2022-01-22 0:33 ` Junio C Hamano
2022-01-22 0:45 ` Junio C Hamano
2022-01-22 0:58 ` [PATCH] checkout: avoid BUG() when hitting a broken repository Junio C Hamano
2022-01-22 8:10 ` Johannes Sixt
2022-01-22 11:55 ` Ævar Arnfjörð Bjarmason
2022-01-23 16:38 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YemTGQZ97vAPUPY0@pobox.com \
--to=tmz@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=psplicha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).