From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4E5EC433EF for ; Wed, 9 Mar 2022 13:42:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233268AbiCINnO (ORCPT ); Wed, 9 Mar 2022 08:43:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233289AbiCINnM (ORCPT ); Wed, 9 Mar 2022 08:43:12 -0500 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E561C17B897 for ; Wed, 9 Mar 2022 05:42:12 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 94C063200D25; Wed, 9 Mar 2022 08:42:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 09 Mar 2022 08:42:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=fYMXyqAbMJqoX+XBmSW4VtcUSJ6CmV7KPSJG7B b3QJA=; b=fXRsuP9yaBmhBaq9pX25PFFqeCEqNgkulHXEYzbRZFU96g/W6IXAFK I5527fkRhu3xE4hBKWHOCf8WehabifETYQgGffursG86Mcd7hNPPfXVhY+74m7oG G31VUAwzu3oKgaQOzFD80pV5QDs0iGlCLCwyqAaUetSGDb95DyQNY1Je446lGBoa es+/PpUGO75Oy/cYwMcjfaURKE8L6CQPJNl2bOqC63TFkmUau1HNty5DMpuNNORr +qFAk6cUPQ2NSG016eJjWXuup9mMfWi+ZnckndoekKjoo9BPWgZEZcxbA4k6Zq+5 oMQC83ds3kNmzh7H/+Uxz9OZ+9wX0njQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=fYMXyqAbMJqoX+XBm SW4VtcUSJ6CmV7KPSJG7Bb3QJA=; b=LTwGPF/bhi1cz+mLpqjmueQfrwBB0GJ9q /pdT4dwP+8nl0Fyg23KaeZR7aKAz1XLC5hK35vF/jq7JjeYkSi1eymZdXWT9lw1C E7AvGSJBjbblIi3yyczpBUldBr7QE3qNlSv8XQosnXWolzGeWEDhwzv4+ETY8pIW DHHxQRcwM1/qn2QoQr0dH71LFh168BI4XBdQmd2kHj4u8wmml+vKpZmuYTcReLiz gDAckVnROrXqGv2urPrSbnRJWQ5AkjVw6pjVMRg1Su5gPs6YzisB0E2Fe+D8A0l1 9ON9aka4k8tQqyGAj7w/aiuGkA83DQDOl6+wnuftmwJeSIEpMct6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddukedgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeeiieelgfekvdfhhffhfffgheejgeejudetleeifffftdeigeefkedvgeegheeifeen ucffohhmrghinhepphhusghlihgtqdhinhgsohigrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Mar 2022 08:42:07 -0500 (EST) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 89f0830e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 9 Mar 2022 13:42:02 +0000 (UTC) Date: Wed, 9 Mar 2022 14:42:00 +0100 From: Patrick Steinhardt To: Junio C Hamano Cc: Neeraj Singh , Neeraj Singh via GitGitGadget , Git List , "Randall S. Becker" , Bagas Sanjaya , Elijah Newren , =?iso-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason , "Neeraj K. Singh" Subject: Re: [PATCH v4 2/4] core.fsync: introduce granular fsync control Message-ID: References: <7a164ba95710b4231d07982fd27ec51022929b81.1643686425.git.gitgitgadget@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WuNnOlzZkz2j7oOc" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org --WuNnOlzZkz2j7oOc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 14, 2022 at 09:17:31AM -0800, Junio C Hamano wrote: > Patrick Steinhardt writes: >=20 > > To summarize my take: while the degree of durability may be something > > that's up for discussions, I think that the current defaults for > > atomicity are bad for users because they can and do lead to repository > > corruption. >=20 > Good summary. >=20 > If the user cares about fsynching loose object files in the right > way, we shouldn't leave loose ref files not following the safe > safety level, regardless of how this new core.fsync knobs would look > like. >=20 > I think we three are in agreement on that. Is there anything I can specifically do to help out with this topic? We have again hit data loss in production because we don't sync loose refs to disk before renaming them into place, so I'd really love to sort out this issue somehow so that I can revive my patch series which fixes the known repository corruption [1]. Alternatively, can we maybe find a way forward with applying a version of my patch series without first settling the bigger question of how we want the overall design to look like? In my opinion repository corruption is a severe bug that needs to be fixed, and it doesn't feel sensible to block such a fix over a discussion that potentially will take a long time to settle. Patrick [1]: http://public-inbox.org/git/cover.1636544377.git.ps@pks.im/ --WuNnOlzZkz2j7oOc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAmIorqcACgkQVbJhu7ck PpTvgQ/+PyNwRnMgjrWlaTABJF99cYrK9wr38gE/9bM5Ra1/h8UhQgds0UgZ/Vk3 H8HQLdKAr3IXsVk37FiM2gH62kOtVv8PHEyH/cMH3C3b58VytQvrOmFd34g5RZ+b yp79QLrkJOOytdZWA8SUYED8GYqgsNzA5dsxG70KsEC6SfczUYtacjX01X1gk5vE oQmCvtfYCZQTrF+WsxzCFZfJ064om+WoKBIV0/l8yU4FrIdnWTCWX6s6LadYJyZu Pn7u+oMkjnWHaSEa/cxYvtZcIX3R5G2ppM2Cjb/IxKBqOz7fZPWIVL/bCjfWLlA/ UIKN87i1vYCF9UKlpjAm/j18fAJir9TWBlWzehg7oG5pGhF/uW4dINHIfYuYjlgz 8AuS6tuOI5b4on9MyQSla2AC0keIJYQe9YpcNY+PcNA2l+c7PxQ3dtdlXJ0SoVbs LVj6XW1miu4BN3lZQFIbL7rDtLKr9mH+rWcsKPHdLeiAHTWkovS+imi6nsnmJxyA hgNJnVTfNH9x5m5rgwtC2Qq8Ncq9qUNDcSlVYY8gkIY01ngNK8/4Jyjkg7TOs5/K c7bx/ntrhCduut2a/8xPHHt2ftExglGzdfOI28CZLXSBlFrhN1NvF0GA0/2KR0Lc PQM7eFzLCrsPwsFU/N9Kma/LX8XBymL3l2rbZPdOTAZg5HFn4wE= =QKDH -----END PGP SIGNATURE----- --WuNnOlzZkz2j7oOc--