From: Frantisek Hrbata <frantisek@hrbata.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Josh Steadmon" <steadmon@google.com>,
"Brandon Williams" <bwilliams.eng@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Jonathan Tan" <jonathantanmy@google.com>
Subject: Re: [PATCH] transport: free local and remote refs in transport_push()
Date: Fri, 20 May 2022 10:56:12 +0200 [thread overview]
Message-ID: <YodXrProOdVzvgQA@fedora> (raw)
In-Reply-To: <220520.8635h438aa.gmgdl@evledraar.gmail.com>
Hello,
On Fri, May 20, 2022 at 10:40:33AM +0200, Ævar Arnfjörð Bjarmason wrote:
>
> On Fri, May 20 2022, Frantisek Hrbata wrote:
>
> > Fix memory leaks in transport_push(), where remote_refs and local_refs
> > are never freed. While at it, remove the unnecessary indenting and make
> > the code hopefully more readable.
>
> If at all possible it would be very nice to split up such re-indenting /
> formatting into another commit, so we can see what the "real" code
> changes are.
of course, I will split it into two patch series and post v2. First with the
indenting adjustment only and second with mem leak fixes.
Thank you
--
Frantisek Hrbata
next prev parent reply other threads:[~2022-05-20 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 8:17 [PATCH] transport: free local and remote refs in transport_push() Frantisek Hrbata
2022-05-20 8:40 ` Ævar Arnfjörð Bjarmason
2022-05-20 8:56 ` Frantisek Hrbata [this message]
2022-05-20 10:35 ` [PATCH v2 0/2] fix memory leaks " Frantisek Hrbata
2022-05-20 10:35 ` [PATCH v2 1/2] transport: remove unnecessary indenting " Frantisek Hrbata
2022-05-20 11:24 ` Ævar Arnfjörð Bjarmason
2022-05-20 11:53 ` Frantisek Hrbata
2022-05-20 10:35 ` [PATCH v2 2/2] transport: free local and remote refs " Frantisek Hrbata
2022-05-20 12:49 ` [PATCH v3 0/3] fix memory leaks " Frantisek Hrbata
2022-05-20 12:49 ` [PATCH v3 1/3] transport: remove unnecessary indenting " Frantisek Hrbata
2022-05-20 12:49 ` [PATCH v3 2/3] transport: unify return values and exit point from transport_push() Frantisek Hrbata
2022-05-20 12:49 ` [PATCH v3 3/3] transport: free local and remote refs in transport_push() Frantisek Hrbata
2022-05-27 20:22 ` [PATCH v3 0/3] fix memory leaks " Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YodXrProOdVzvgQA@fedora \
--to=frantisek@hrbata.com \
--cc=avarab@gmail.com \
--cc=bwilliams.eng@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=pclouds@gmail.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).