git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Michael J Gruber <git@grubix.eu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] config: correct log.showRoot description
Date: Tue, 14 Jun 2022 21:50:32 -0400	[thread overview]
Message-ID: <Yqk66CTVbX22Xi+e@nand.local> (raw)
In-Reply-To: <b7aa801c3995fffdce37d90adba9253485b616e3.1655223201.git.git@grubix.eu>

On Tue, Jun 14, 2022 at 06:14:22PM +0200, Michael J Gruber wrote:
> diff --git a/Documentation/config/log.txt b/Documentation/config/log.txt
> index 456eb07800..b210f24cca 100644
> --- a/Documentation/config/log.txt
> +++ b/Documentation/config/log.txt
> @@ -40,10 +40,10 @@ log.graphColors::
>  	history lines in `git log --graph`.
>
>  log.showRoot::
> -	If true, the initial commit will be shown as a big creation event.
> -	This is equivalent to a diff against an empty tree.
> -	Tools like linkgit:git-log[1] or linkgit:git-whatchanged[1], which
> -	normally hide the root commit will now show it. True by default.
> +	If `false`, tools like linkgit:git-log[1] or linkgit:git-whatchanged[1]
> +	will not treat the initial commit as a big creation event.  Any root
> +	commits in `git log -p` output would be shown without a diff attached.
> +	The default is `true`.

This looks good to me. An alternative approach which would work to would
be to replace "If `true`" with "When `true`". I have a vague preference
towards the latter, since it explains what log.showRoot does, rather
than what it does not do.

But this works just as well, and I think that I'm splitting hairs
anyways ;).

Thanks,
Taylor

      reply	other threads:[~2022-06-15  1:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 16:14 [PATCH] config: correct log.showRoot description Michael J Gruber
2022-06-15  1:50 ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yqk66CTVbX22Xi+e@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@grubix.eu \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).