From: Taylor Blau <me@ttaylorr.com>
To: "kylezhao(赵柯宇)" <kylezhao@tencent.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Kyle Zhao via GitGitGadget" <gitgitgadget@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"Derrick Stolee" <derrickstolee@github.com>
Subject: Re: [Internet]Re: [PATCH v2] send-pack.c: add config push.useBitmaps
Date: Thu, 16 Jun 2022 17:17:45 -0400 [thread overview]
Message-ID: <Yqud+Y6LgkbmBOBj@nand.local> (raw)
In-Reply-To: <be5afab25a5b44b3af797c0c8b75f5e6@tencent.com>
On Thu, Jun 16, 2022 at 03:11:09PM +0000, kylezhao(赵柯宇) wrote:
> > At the time I didn't, because as noted in a follow-up I'd lost my test
> > case by the time I read that, but it seems you haven't, and have a
> > current test case.
>
> I tried to find a test case in open-source projects, and finally found one.
> $ git clone https://github.com/JetBrains/intellij-community.git --bare
> $ cd intellij-community.git
> $ git repack -adb
> $ GIT_TRACE=1 git push . master:test1
I wouldn't expect this to push any objects at all, since you're pushing
to a repository that already has all of the objects contained in
`master`.
A more representative test might be something like:
$ git clone https://github.com/JetBrains/intellij-community.git --bare
$ cd intellij-community.git
$ git repack -adb
$ git rev-parse HEAD >in
$ time git pack-objects --revs --stdout <in >/dev/null
# move the bitmap away so we don't use it
$ mv objects/pack/pack-*.bitmap{,.bak}
$ time git pack-objects --revs --stdout <in >/dev/null
Thanks,
Taylor
next prev parent reply other threads:[~2022-06-16 21:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 11:08 [PATCH] send-pack.c: add config push.useBitmaps Kyle Zhao via GitGitGadget
2022-06-15 13:09 ` Derrick Stolee
2022-06-15 21:24 ` Taylor Blau
2022-06-15 19:47 ` Ævar Arnfjörð Bjarmason
2022-06-15 21:32 ` Taylor Blau
2022-06-16 2:13 ` [Internet]Re: " kylezhao(赵柯宇)
2022-06-16 3:36 ` [PATCH v2] " Kyle Zhao via GitGitGadget
2022-06-16 13:02 ` Derrick Stolee
2022-06-16 13:38 ` Ævar Arnfjörð Bjarmason
2022-06-16 15:11 ` [Internet]Re: " kylezhao(赵柯宇)
2022-06-16 21:17 ` Taylor Blau [this message]
2022-06-16 18:12 ` Junio C Hamano
2022-06-16 21:04 ` Jeff King
2022-06-17 3:59 ` [PATCH v3] " Kyle Zhao via GitGitGadget
2022-06-17 17:01 ` Junio C Hamano
2022-06-17 19:06 ` [PATCH v4] " Kyle Zhao via GitGitGadget
2022-06-17 21:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqud+Y6LgkbmBOBj@nand.local \
--to=me@ttaylorr.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kylezhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).