Re: [PATCH] vimdiff: make layout engine more robust against user vim settings

[Fernando Ramos <greenfoo@u92.eu>]

On 22/07/08 01:15PM, Junio C Hamano wrote:
>
> Interesting.  Does that mean that the end-user setting that was
> problematic with the new layout engine would have also broken the
> layout before your series?

Surprisingly enough, no. Turns out the commands used before the new layout
engine was introduced did *not* use 'split' nor 'vertical split' (which are the
commands affected by those two global settings).

Instead, it relayed on the fact that 'vim -d' always opens splits vertically and
then readjusted window positions with 'wincmd [HJKL]'.

The old way was limited in the amount of things that could be achieved and
that's why it was changed... but I completely missed those two global settings
capable of changing the behaviour of the new commands.


> > In order to fix this we can append special keyword 'letfabove' to each
> 
> Presumably "leftabove" was meant here.

You are right. Sorry.


> Will queue.  Thanks.

Thank you!