From: Jeff King <peff@peff.net>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] merge-file: fix build warning with gcc 4.8.5
Date: Fri, 29 Jul 2022 21:40:32 -0400 [thread overview]
Message-ID: <YuSL/2N29cCy9Dzd@coredump.intra.peff.net> (raw)
In-Reply-To: <YuR5Jado2LrtZUjP@danh.dev>
On Sat, Jul 30, 2022 at 07:19:49AM +0700, Đoàn Trần Công Danh wrote:
> > Tested on a debian jessie chroot using gcc-4.8 and 4.9. Though note that
> > you also need to manually specify -std=gnu99 to get it to work at all
> > with those compilers these days! So I kind of wonder if it's even worth
> > catering to their warnings automatically.
>
> Well, config.mak.uname automatically adds -std=c99 for RHEL 7 and
> CentOS7. Can we add the same things for Debian? Or should we just
> remove both?
Ah, I didn't know about that. No, I don't think there's any reason to
remove them. If people are able to compile out of the box there, then my
patch to config.mak.dev may be worth doing.
As far as adding a similar config.mak.uname thing for Debian, I don't
have a strong opinion. Jessie is far beyond being supported, so I'd
probably wait to see if somebody who actually cares proposes a patch.
-Peff
next prev parent reply other threads:[~2022-07-30 1:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 9:05 [PATCH] merge-file: fix build warning with gcc 4.8.5 Đoàn Trần Công Danh
2022-07-29 15:48 ` Junio C Hamano
2022-07-29 19:53 ` Jeff King
2022-07-29 19:54 ` Jeff King
2022-07-29 20:48 ` Eric Sunshine
2022-07-29 21:00 ` Jeff King
2022-07-29 21:23 ` Junio C Hamano
2022-07-30 0:19 ` Đoàn Trần Công Danh
2022-07-30 1:40 ` Jeff King [this message]
2022-07-30 1:46 ` brian m. carlson
2022-07-30 23:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuSL/2N29cCy9Dzd@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox