git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Meet Soni <meetsoni3017@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
	shejialuo@gmail.com, karthik nayak <karthik.188@gmail.com>,
	Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Subject: Re: [GSoC][Proposal RFC] Consolidate ref-related functionality into git-refs
Date: Thu, 3 Apr 2025 12:28:06 +0200	[thread overview]
Message-ID: <Z-5itjoHBV-dEPwU@pks.im> (raw)
In-Reply-To: <CAPhwyn2GugzXg5LgcdMGjrvP9kAvCFj31RXrUpp7ZJdoGfiyKA@mail.gmail.com>

On Thu, Apr 03, 2025 at 03:35:09PM +0530, Meet Soni wrote:
> On Wed, 2 Apr 2025 at 13:51, Patrick Steinhardt <ps@pks.im> wrote:
> > On Tue, Apr 01, 2025 at 07:07:21AM +0530, Meet Soni wrote:
> > >     2. Tests:
> > >       Develop comprehensive tests to verify that the new subcommands function as
> > >       expected. This will involve creating a range of tests, including shell
> > >       scripts and/or unit tests located in the t/ directory. For the existing
> > >       tests covering the legacy commands targeted for consolidation, the plan is
> > >       to retain them initially—even if this results in some duplication—with the
> > >       intention of deprecating them gradually over time.
> > >     3. Update old usage:
> > >       Modify all call sites of the legacy commands to invoke the newly created
> > >       subcommands, ensuring a smooth transition and seamless integration with
> > >       the consolidated command.
> >
> > This would be nice indeed, but it's not necessary as part of the GSoC
> > project from my point of view. The old commands won't go away anytime
> > soon as they are extensively used in scripts outside of our control.
> >
> I wonder if this is a better candidate for "Post GSoC" section maybe?

Potentially, yeah. It doesn't really have to be part of the proposal in
the first place from my point of view, but having a section about future
work after the GSoC wouldn't hurt, either.

> > > I think if permitted to start early, I can consolidate one more command within
> > > the GSoC period.
> >
> > We cannot keep you from doing this, but please keep in mind that if we
> > end up picking a different candidate for this project we would favor
> > their work so that they can successfully finish GSoC. So I would
> > definitely wait until you've been selected before starting to work on
> > anything.
> >
> I completely understand. Just to clarify, I meant that if I'm fortunate enough
> to be selected, I’d be eager to start contributing during the community
> bonding period--only if it's allowed--so that I can try to consolidate one more
> command within the GSoC period.

We won't give you a strict time schedule of "you first do that and then
do that". Only thing that I'd like to avoid is that you're basically
already done before the project starts ;)

I'd just define these additinoal subcommands as stretch goals and then
it's fine.

Patrick

  reply	other threads:[~2025-04-03 10:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01  1:37 [GSoC][Proposal RFC] Consolidate ref-related functionality into git-refs Meet Soni
2025-04-02  8:21 ` Patrick Steinhardt
2025-04-03 10:05   ` Meet Soni
2025-04-03 10:28     ` Patrick Steinhardt [this message]
2025-04-04 11:46 ` Karthik Nayak
2025-04-04 11:48   ` Patrick Steinhardt
2025-04-04 11:52     ` Karthik Nayak
2025-04-04 12:24       ` [GSoC][Proposal RFC v2] " Meet Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-5itjoHBV-dEPwU@pks.im \
    --to=ps@pks.im \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=meetsoni3017@gmail.com \
    --cc=shejialuo@gmail.com \
    --cc=shyamthakkar001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).