Re: [PATCH 06/20] t: introduce PERL_TEST_HELPERS prerequisite

[Patrick Steinhardt <ps@pks.im>]

On Thu, Mar 20, 2025 at 02:55:34PM -0400, Eric Sunshine wrote:
> On Thu, Mar 20, 2025 at 5:36 AM Patrick Steinhardt <ps@pks.im> wrote:
> > [...]
> > Introduce a new PERL_TEST_HELPERS prerequisite that guards all tests
> > that require Perl. This prerequisite is explicitly different than the
> > preexisting PERL prerequisite:
> > [...]
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
> > ---
> > diff --git a/t/t0008-ignores.sh b/t/t0008-ignores.sh
> > @@ -5,6 +5,12 @@ test_description=check-ignore
> > +if ! test_have_prereq PERL_TEST_HELPERS
> > +then
> > +       skip_all='skipping ignores tests; Perl not available'
> > +       test_done
> > +fi
> > diff --git a/t/t4103-apply-binary.sh b/t/t4103-apply-binary.sh
> > @@ -11,6 +11,12 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
> > +if ! test_have_prereq PERL_TEST_HELPERS
> > +then
> > +       skip_all='skipping ignores tests; Perl not available'
> > +       test_done
> > +fi
> 
> This message seems to have been copy/pasted. Should it be instead
> "skipping apply-binary tests; Perl not available"?

Yup, good catch!

Patrick