From: Patrick Steinhardt <ps@pks.im>
To: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org, "D . Ben Knoble" <ben.knoble@gmail.com>
Subject: Re: [GSoC PATCH v3] userdiff: add builtin driver for INI files
Date: Mon, 31 Mar 2025 09:38:31 +0200 [thread overview]
Message-ID: <Z-pGdyh0eG3xSe4W@pks.im> (raw)
In-Reply-To: <20250331031309.94682-1-lucasseikioshiro@gmail.com>
On Mon, Mar 31, 2025 at 12:13:09AM -0300, Lucas Seiki Oshiro wrote:
> Add a new builtin driver for generic INI files (e. g. the gitconfig
> files), where:
>
> - the funcname regular expression matches section names, i. e. any
> string between brackets at the beginning of the line, with or without
> indentation;
>
> - word_regex matches any word with one or more non-whitespace
> characters without checking if it is a valid variable name or value.
>
> Also add tests for the new userdiff driver. These files define sections
> and subsections, with and without indentation.
>
> Helped-by: Patrick Steinhardt <ps@pks.im>
> Helped-by: D. Ben Knoble <ben.knoble@gmail.com>
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
This commit message reads quite nicely now. The changes also look
sensible to me. Thanks, I've got nothing else to add!
Patrick
prev parent reply other threads:[~2025-03-31 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 3:13 [GSoC PATCH v3] userdiff: add builtin driver for INI files Lucas Seiki Oshiro
2025-03-31 7:38 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-pGdyh0eG3xSe4W@pks.im \
--to=ps@pks.im \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=lucasseikioshiro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).