git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: Akshay Hegde <lists+git@akshay.is>
Subject: Re: meson: Installing completions
Date: Tue, 1 Apr 2025 11:58:49 +0200	[thread overview]
Message-ID: <Z-u42Sm613hMj1Ft@pks.im> (raw)
In-Reply-To: <Z-uLqQd7QHZq-tB7@akshay.is>

Hi,

On Mon, Mar 31, 2025 at 11:46:01PM -0700, Akshay Hegde wrote:
> Hi there,
> 
> I found some extra time today so I thought I'd try moving my git
> install over to using the new meson build system. Everything went
> surprisingly smoothly, which I really appreciated, so thank you!

great, thanks for testing!

> However, one thing that confused me was that the completions were never
> installed automatically as part of `meson install`, even though
> I specified them under the '-Dcontrib' option.
> 
> I just wanted to double check if I'm supposed to install them manually,
> or if I missed enabling some options (I looked through the top-level
> meson_options.txt and meson.build files and I don't think I did.)

For now the status quo is that you have to install them manually, which
indeed isn't optimal. It matches our Makefile, which never installed
those completions, either. But that by itself isn't a good enough
argument from my perspective that it needs to be the same with Meson.

The biggest question though is whether distros are aligned enough for us
to provide standard installation paths. That is, do all distros end up
installing bash completion into "/usr/share/bash-completion"? What are
the desired directories for tcsh and zsh completion?

If there is enough standardization then yes, I totally think we should
start installing completion scripts automatically.

Patrick

  reply	other threads:[~2025-04-01  9:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01  6:46 meson: Installing completions Akshay Hegde
2025-04-01  9:58 ` Patrick Steinhardt [this message]
2025-04-01 17:43   ` Akshay Hegde
2025-04-02  0:58     ` Todd Zullinger
2025-04-02 11:33       ` Patrick Steinhardt
2025-04-02 14:05         ` Todd Zullinger
2025-04-07  8:01           ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-u42Sm613hMj1Ft@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=lists+git@akshay.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).