git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Akshay Hegde <lists+git@akshay.is>
To: git@vger.kernel.org
Subject: meson: Installing completions
Date: Mon, 31 Mar 2025 23:46:01 -0700	[thread overview]
Message-ID: <Z-uLqQd7QHZq-tB7@akshay.is> (raw)

Hi there,

I found some extra time today so I thought I'd try moving my git
install over to using the new meson build system. Everything went
surprisingly smoothly, which I really appreciated, so thank you!

However, one thing that confused me was that the completions were never
installed automatically as part of `meson install`, even though
I specified them under the '-Dcontrib' option.

I just wanted to double check if I'm supposed to install them manually,
or if I missed enabling some options (I looked through the top-level
meson_options.txt and meson.build files and I don't think I did.)

I'm calling meson setup like so:

    meson setup meson-git-build --prefix=/opt/personal/git/versions/2.49.0 \
        --libdir=/opt/personal/git/versions/2.49.0/lib --buildtype=release \
        --wrap-mode=nofallback --backend=ninja \
        -Dmacos_use_homebrew_gettext=false -Dcontrib=completion,subtree

And I do see both subtree and completion modules being built in the
'meson compile' logs and indeed, I see that git-subtree was
automatically installed, as expected:

    Installing contrib/subtree/git-subtree to /opt/personal/git/versions/2.49.0/libexec/git-core

...So I would have expected the completion module to be automatically
installed as well, but this didn't happen. Rather, it merely got copied
to the internal build folder:

    [669/669] /opt/personal/meson/bin/meson --internal copy ../contrib/completion/git-completion.tcsh contrib/completion/git-completion.tcsh

Of course, I can manually install these to the appropriate locations,
but just checking to make sure I didn't miss anything.

Cheers,
-- 
	Akshay


             reply	other threads:[~2025-04-01  6:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01  6:46 Akshay Hegde [this message]
2025-04-01  9:58 ` meson: Installing completions Patrick Steinhardt
2025-04-01 17:43   ` Akshay Hegde
2025-04-02  0:58     ` Todd Zullinger
2025-04-02 11:33       ` Patrick Steinhardt
2025-04-02 14:05         ` Todd Zullinger
2025-04-07  8:01           ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-uLqQd7QHZq-tB7@akshay.is \
    --to=lists+git@akshay.is \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).