git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shejialuo <shejialuo@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, git@jowil.de, Jeff King <peff@peff.net>
Subject: Re: [PATCH 4/4] tag: "git tag" refuses to use HEAD as a tagname
Date: Mon, 2 Dec 2024 21:01:21 +0800	[thread overview]
Message-ID: <Z02voaSNYRciv38z@ArchLinux> (raw)
In-Reply-To: <20241202070714.3028549-5-gitster@pobox.com>

On Mon, Dec 02, 2024 at 04:07:14PM +0900, Junio C Hamano wrote:

[snip]

> diff --git a/refs.c b/refs.c
> index a24bfe3845..01ef2a3093 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -735,7 +735,7 @@ int check_branch_ref(struct strbuf *sb, const char *name)
>  
>  int check_tag_ref(struct strbuf *sb, const char *name)
>  {
> -	if (name[0] == '-')
> +	if (name[0] == '-' || !strcmp(name, "HEAD"))

I am wondering whether we should also update "check_refname_format"
function to report "refs/heads/HEAD" and "refs/tags/HEAD" is bad ref
name.

>  		return -1;
>  
>  	strbuf_reset(sb);

Thanks,
Jialuo

  parent reply	other threads:[~2024-12-02 13:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02  7:07 [PATCH 0/4] forbid HEAD as a tagname Junio C Hamano
2024-12-02  7:07 ` [PATCH 1/4] refs: move ref name helpers around Junio C Hamano
2024-12-02 20:37   ` Jeff King
2024-12-03  1:23     ` Junio C Hamano
2024-12-02  7:07 ` [PATCH 2/4] refs: drop strbuf_ prefix from helpers Junio C Hamano
2024-12-02 20:51   ` Jeff King
2024-12-02  7:07 ` [PATCH 3/4] t5604: do not expect that HEAD is a valid tagname Junio C Hamano
2024-12-02 12:19   ` Kristoffer Haugsbakk
2024-12-02 21:00     ` Jeff King
2024-12-02 21:09       ` Kristoffer Haugsbakk
2024-12-03  1:29       ` Junio C Hamano
2024-12-05 20:25         ` Jeff King
2024-12-02 20:52   ` Jeff King
2024-12-02  7:07 ` [PATCH 4/4] tag: "git tag" refuses to use HEAD as a tagname Junio C Hamano
2024-12-02 10:54   ` Patrick Steinhardt
2024-12-02 13:01   ` shejialuo [this message]
2024-12-03  1:30     ` Junio C Hamano
2024-12-05 20:26       ` Jeff King
2024-12-05 20:27         ` Jeff King
2024-12-02 20:42   ` Rubén Justo
2024-12-03  1:35     ` Junio C Hamano
2024-12-02 21:03   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z02voaSNYRciv38z@ArchLinux \
    --to=shejialuo@gmail.com \
    --cc=git@jowil.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).