git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <pks@pks.im>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
	git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 06/10] refs: skip collision checks in initial transactions
Date: Mon, 25 Nov 2024 06:52:30 +0100	[thread overview]
Message-ID: <Z0QQnqZ5x9Y-Js8V@pks.im> (raw)
In-Reply-To: <afed1ddc-90fd-446a-9da0-b8e8f3fbb903@app.fastmail.com>

On Wed, Nov 20, 2024 at 11:42:29AM +0100, Kristoffer Haugsbakk wrote:
> Hi
> 
> On Wed, Nov 20, 2024, at 08:51, Patrick Steinhardt wrote:
> > While we generally cannot avoid the first check, the second check is
> > superfluous in cases where the transaction is an initial one in an
> > otherwise empty ref store. The check results in multiple ref reads as
> > well as the creation of a ref iterator for every ref we're checking,
> > which adds up quite fast when performing the check for many refs.
> >
> > Introduce a new flag that allows us to skip this check and wire it up in
> > such that the backends pass it when running an initial transaction. This
> 
> Missing word? “wire it up in such that”.
> 
> Maybe: “wire it up so that”.

Ah, indeed. Will fix. Thanks!

Patrick

  reply	other threads:[~2024-11-25  5:52 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08  9:34 [PATCH 00/10] refs: optimize ref format migrations Patrick Steinhardt
2024-11-08  9:34 ` [PATCH 01/10] refs: allow passing flags when setting up a transaction Patrick Steinhardt
2024-11-11 10:30   ` karthik nayak
2024-11-11 12:53     ` Patrick Steinhardt
2024-11-08  9:34 ` [PATCH 02/10] refs/files: move logic to commit initial transaction Patrick Steinhardt
2024-11-08  9:34 ` [PATCH 03/10] refs: introduce "initial" transaction flag Patrick Steinhardt
2024-11-08  9:34 ` [PATCH 04/10] refs/files: support symbolic and root refs in initial transaction Patrick Steinhardt
2024-11-11 10:42   ` karthik nayak
2024-11-11 12:53     ` Patrick Steinhardt
2024-11-08  9:34 ` [PATCH 05/10] refs: use "initial" transaction semantics to migrate refs Patrick Steinhardt
2024-11-11 10:43   ` karthik nayak
2024-11-08  9:34 ` [PATCH 06/10] refs: skip collision checks in initial transactions Patrick Steinhardt
2024-11-11 10:53   ` karthik nayak
2024-11-08  9:34 ` [PATCH 07/10] refs: don't normalize log messages with `REF_SKIP_CREATE_REFLOG` Patrick Steinhardt
2024-11-08  9:34 ` [PATCH 08/10] reftable/writer: optimize allocations by using a scratch buffer Patrick Steinhardt
2024-11-08  9:34 ` [PATCH 09/10] reftable/block: rename `block_writer::buf` variable Patrick Steinhardt
2024-11-08  9:34 ` [PATCH 10/10] reftable/block: optimize allocations by using scratch buffer Patrick Steinhardt
2024-11-11 10:57 ` [PATCH 00/10] refs: optimize ref format migrations karthik nayak
2024-11-11 12:53   ` Patrick Steinhardt
2024-11-20  7:04     ` Junio C Hamano
2024-11-20  7:50       ` Patrick Steinhardt
2024-11-20 10:25         ` Christian Couder
2024-11-25  5:52           ` Patrick Steinhardt
2024-11-20  7:51 ` [PATCH v2 " Patrick Steinhardt
2024-11-20  7:51   ` [PATCH v2 01/10] refs: allow passing flags when setting up a transaction Patrick Steinhardt
2024-11-20 10:19     ` Christian Couder
2024-11-20  7:51   ` [PATCH v2 02/10] refs/files: move logic to commit initial transaction Patrick Steinhardt
2024-11-20  7:51   ` [PATCH v2 03/10] refs: introduce "initial" transaction flag Patrick Steinhardt
2024-11-20  7:51   ` [PATCH v2 04/10] refs/files: support symbolic and root refs in initial transaction Patrick Steinhardt
2024-11-20  7:51   ` [PATCH v2 05/10] refs: use "initial" transaction semantics to migrate refs Patrick Steinhardt
2024-11-20  7:51   ` [PATCH v2 06/10] refs: skip collision checks in initial transactions Patrick Steinhardt
2024-11-20 10:21     ` Christian Couder
2024-11-25  5:52       ` Patrick Steinhardt
2024-11-20 10:42     ` Kristoffer Haugsbakk
2024-11-25  5:52       ` Patrick Steinhardt [this message]
2024-11-20  7:51   ` [PATCH v2 07/10] refs: don't normalize log messages with `REF_SKIP_CREATE_REFLOG` Patrick Steinhardt
2024-11-20  7:51   ` [PATCH v2 08/10] reftable/writer: optimize allocations by using a scratch buffer Patrick Steinhardt
2024-11-20 10:21     ` Christian Couder
2024-11-25  5:52       ` Patrick Steinhardt
2024-11-20  7:51   ` [PATCH v2 09/10] reftable/block: rename `block_writer::buf` variable Patrick Steinhardt
2024-11-20  7:51   ` [PATCH v2 10/10] reftable/block: optimize allocations by using scratch buffer Patrick Steinhardt
2024-11-20 10:22     ` Christian Couder
2024-11-25  6:27 ` [PATCH v3 00/10] refs: optimize ref format migrations Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 01/10] refs: allow passing flags when setting up a transaction Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 02/10] refs/files: move logic to commit initial transaction Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 03/10] refs: introduce "initial" transaction flag Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 04/10] refs/files: support symbolic and root refs in initial transaction Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 05/10] refs: use "initial" transaction semantics to migrate refs Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 06/10] refs: skip collision checks in initial transactions Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 07/10] refs: don't normalize log messages with `REF_SKIP_CREATE_REFLOG` Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 08/10] reftable/writer: optimize allocations by using a scratch buffer Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 09/10] reftable/block: rename `block_writer::buf` variable Patrick Steinhardt
2024-11-25  6:27   ` [PATCH v3 10/10] reftable/block: optimize allocations by using scratch buffer Patrick Steinhardt
2024-11-25  6:29   ` [PATCH v3 00/10] refs: optimize ref format migrations Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z0QQnqZ5x9Y-Js8V@pks.im \
    --to=pks@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).