From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/4] ci/lib: use echo instead of printf to set up sections
Date: Sat, 7 Dec 2024 10:13:11 +0100 [thread overview]
Message-ID: <Z1QRp8jFJPYdNmQk@ugly> (raw)
In-Reply-To: <20241206-pks-ci-section-fixes-v1-3-7ab1b69e3648@pks.im>
On Fri, Dec 06, 2024 at 12:10:15PM +0100, Patrick Steinhardt wrote:
>We use printf to set up sections with GitLab CI even though we could
>trivially use echo.
>
probably not a good idea, because the file is also included from plain
sh scripts, which may invoke an `echo` that cannot deal with \escapes.
at least potentially.
>This may cause problems in case the argument passed to `begin_group ()`
>or `end_group ()` contains formatting directives as we use them as part
>of the formatting string.
>
that can be fixed properly by using the %s expando.
>+++ b/ci/lib.sh
>- printf "\e[0Ksection_start:$(date +%s):$(echo "$1" | tr ' ' _)[collapsed=true]\r\e[0K$1\n"
>+ echo "\e[0Ksection_start:$(date +%s):$(echo "$1" | tr ' ' _)[collapsed=true]\r\e[0K$1"
next prev parent reply other threads:[~2024-12-07 9:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 11:10 [PATCH 0/4] Random improvements to GitLab CI Patrick Steinhardt
2024-12-06 11:10 ` [PATCH 1/4] gitlab-ci: update macOS images to Sonoma Patrick Steinhardt
2024-12-06 11:39 ` karthik nayak
2024-12-06 12:02 ` Patrick Steinhardt
2024-12-07 9:49 ` karthik nayak
2024-12-06 11:10 ` [PATCH 2/4] ci/lib: remove duplicate trap to end "CI setup" group Patrick Steinhardt
2024-12-06 11:10 ` [PATCH 3/4] ci/lib: use echo instead of printf to set up sections Patrick Steinhardt
2024-12-07 9:13 ` Oswald Buddenhagen [this message]
2024-12-10 11:56 ` Patrick Steinhardt
2024-12-06 11:10 ` [PATCH 4/4] ci/lib: fix "CI setup" sections with GitLab CI Patrick Steinhardt
2024-12-06 11:46 ` karthik nayak
2024-12-06 11:47 ` [PATCH 0/4] Random improvements to " karthik nayak
2024-12-06 12:02 ` Patrick Steinhardt
2024-12-10 12:01 ` [PATCH v2 " Patrick Steinhardt
2024-12-10 12:01 ` [PATCH v2 1/4] gitlab-ci: update macOS images to Sonoma Patrick Steinhardt
2024-12-10 12:01 ` [PATCH v2 2/4] ci/lib: remove duplicate trap to end "CI setup" group Patrick Steinhardt
2024-12-10 12:01 ` [PATCH v2 3/4] ci/lib: do not interpret escape sequences in `group ()` arguments Patrick Steinhardt
2024-12-11 12:37 ` Toon Claes
2024-12-12 6:47 ` Patrick Steinhardt
2024-12-10 12:01 ` [PATCH v2 4/4] ci/lib: fix "CI setup" sections with GitLab CI Patrick Steinhardt
2024-12-12 6:47 ` [PATCH v3 0/4] Random improvements to " Patrick Steinhardt
2024-12-12 6:47 ` [PATCH v3 1/4] gitlab-ci: update macOS images to Sonoma Patrick Steinhardt
2024-12-12 6:47 ` [PATCH v3 2/4] ci/lib: remove duplicate trap to end "CI setup" group Patrick Steinhardt
2024-12-12 6:47 ` [PATCH v3 3/4] ci/lib: do not interpret escape sequences in `group ()` arguments Patrick Steinhardt
2024-12-12 6:47 ` [PATCH v3 4/4] ci/lib: fix "CI setup" sections with GitLab CI Patrick Steinhardt
2024-12-12 11:57 ` [PATCH v3 0/4] Random improvements to " Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1QRp8jFJPYdNmQk@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).