From: Patrick Steinhardt <ps@pks.im>
To: shejialuo <shejialuo@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 00/14] Stop using `the_repository` in some trivial cases
Date: Fri, 27 Dec 2024 15:26:26 +0100 [thread overview]
Message-ID: <Z265EvdDt0ynGC1M@pks.im> (raw)
In-Reply-To: <Z2Fygp-5pFQi1p41@ArchLinux>
On Tue, Dec 17, 2024 at 08:45:54PM +0800, shejialuo wrote:
> On Tue, Dec 17, 2024 at 07:43:47AM +0100, Patrick Steinhardt wrote:
> > Hi,
> >
> > this small patch series performs some refactorings to stop using
> > `the_repository` in several subsystems. There wasn't really any
> > criterium for which subsystems I picked, except that all of them have
> > been trivial to convert.
> >
> > In this patch series I'm merely bubbling up `the_repository` one more
> > layer even though some calling contexts already have a repository
> > available. For the sake of triviality I decided not to handle these
> > cases though and instead let a future patch series worry about them.
> >
>
> Actually, I am excited to see that we remove the global variable
> "the_repository" in some subsystems because I have seen every patch with
> "<subsystem>: stop using `the_repository`".
>
> By this, we make the problem smaller, which is good. I have read through
> all the patches, which looks to me.
Thanks for your review!
Patrick
next prev parent reply other threads:[~2024-12-27 14:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 6:43 [PATCH 00/14] Stop using `the_repository` in some trivial cases Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 01/14] progress: stop using `the_repository` Patrick Steinhardt
2024-12-31 6:42 ` Karthik Nayak
2025-01-06 20:57 ` Toon Claes
2025-01-07 7:19 ` Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 02/14] pager: " Patrick Steinhardt
2024-12-17 12:17 ` shejialuo
2024-12-31 6:55 ` Karthik Nayak
2024-12-17 6:43 ` [PATCH 03/14] trace: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 04/14] serve: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 05/14] send-pack: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 06/14] server-info: " Patrick Steinhardt
2024-12-17 12:31 ` shejialuo
2024-12-17 6:43 ` [PATCH 07/14] diagnose: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 08/14] mailinfo: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 09/14] credential: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 10/14] resolve-undo: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 11/14] tmp-objdir: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 12/14] add-interactive: " Patrick Steinhardt
2024-12-17 6:44 ` [PATCH 13/14] graph: " Patrick Steinhardt
2024-12-17 6:44 ` [PATCH 14/14] match-trees: " Patrick Steinhardt
2024-12-17 12:45 ` [PATCH 00/14] Stop using `the_repository` in some trivial cases shejialuo
2024-12-27 14:26 ` Patrick Steinhardt [this message]
2025-01-07 11:41 ` Karthik Nayak
2025-01-07 21:12 ` Toon Claes
2025-01-07 21:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z265EvdDt0ynGC1M@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=shejialuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).