From: Jonathan Nieder <jrnieder@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Toon Claes <toon@iotcl.com>,
Andy Koppe <andy.koppe@gmail.com>
Subject: Re: [PATCH v2 11/12] t/Makefile: make "check-meson" work with Dash
Date: Thu, 2 Jan 2025 16:37:49 +0100 [thread overview]
Message-ID: <Z3ayzUEfW1xd4Up0@google.com> (raw)
In-Reply-To: <20241227-b4-pks-meson-docs-v2-11-f61e63edbfa1@pks.im>
Hi,
Patrick Steinhardt wrote:
> The "check-meson" target uses process substitution to check whether
> extracted contents from "meson.build" match expected contents. Process
> substitution is unportable though and thus the target will fail when
> using for example Dash.
>
> Fix this by writing data into a temporary directory.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> t/.gitignore | 1 +
> t/Makefile | 12 +++++++-----
> 2 files changed, 8 insertions(+), 5 deletions(-)
Without this, I get the error described in
https://lore.kernel.org/git/CAHWeT-boK3x6mup11boEinNDQiAxxf0vwvZkxsGRc_GRvXYA8g@mail.gmail.com/
('/bin/sh: 10: Syntax error: "(" unexpected'), and with this, the
build in the Debian buildd environment succeeds.
Tested-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks for fixing it.
Sincerely,
Jonathan
next prev parent reply other threads:[~2025-01-02 15:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 8:48 [PATCH 00/10] meson: wire up missing HTML documentation Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 01/10] meson: wire up support for AsciiDoctor Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 02/10] meson: properly wire up dependencies for our docs Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 03/10] meson: fix generation of merge tools Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 04/10] meson: generate HTML pages for all man page categories Patrick Steinhardt
2024-12-23 11:52 ` Toon Claes
2024-12-27 13:58 ` Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 05/10] Documentation: inline user-manual.conf Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 06/10] meson: generate user manual Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 07/10] Documentation: refactor "api-index.sh" for out-of-tree builds Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 08/10] Documentation: refactor "howto-index.sh" " Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 09/10] meson: generate articles Patrick Steinhardt
2024-12-13 8:48 ` [PATCH 10/10] meson: install static files for HTML documentation Patrick Steinhardt
2024-12-23 11:51 ` [PATCH 00/10] meson: wire up missing " Toon Claes
2024-12-27 13:58 ` Patrick Steinhardt
2025-01-03 7:58 ` How to use Meson (was: [PATCH 00/10] meson: wire up missing HTML documentation]) Toon Claes
2025-01-03 8:35 ` Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 00/12] meson: wire up missing HTML documentation Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 01/12] meson: wire up support for AsciiDoctor Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 02/12] meson: properly wire up dependencies for our docs Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 03/12] meson: fix generation of merge tools Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 04/12] meson: generate HTML pages for all man page categories Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 05/12] Documentation: inline user-manual.conf Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 06/12] meson: generate user manual Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 07/12] Documentation: refactor "api-index.sh" for out-of-tree builds Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 08/12] Documentation: refactor "howto-index.sh" " Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 09/12] meson: generate articles Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 10/12] meson: install static files for HTML documentation Patrick Steinhardt
2024-12-27 13:59 ` [PATCH v2 11/12] t/Makefile: make "check-meson" work with Dash Patrick Steinhardt
2025-01-02 15:37 ` Jonathan Nieder [this message]
2025-01-02 15:41 ` Junio C Hamano
2025-01-03 0:05 ` Junio C Hamano
2024-12-27 13:59 ` [PATCH v2 12/12] Documentation: wire up sanity checks for Meson Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3ayzUEfW1xd4Up0@google.com \
--to=jrnieder@gmail.com \
--cc=andy.koppe@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).