From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] object-file: retry linking file into place when occluding file vanishes
Date: Mon, 6 Jan 2025 12:11:47 +0100 [thread overview]
Message-ID: <Z3u6c1UVQyZuHLdk@pks.im> (raw)
In-Reply-To: <20250103195942.GA3212696@coredump.intra.peff.net>
On Fri, Jan 03, 2025 at 02:59:42PM -0500, Jeff King wrote:
> On Fri, Jan 03, 2025 at 02:40:58PM -0500, Jeff King wrote:
>
> > I suspect there's a way to write this as a loop that would be more
> > structured, but it would be a bigger refactor. Bonus points if it also
> > get rid of the try_rename goto, too. ;)
> >
> > I'm OK punting on that, though.
>
> For fun, here's a version without any goto's in it, that should behave
> the same. But it would be very easy to miss a case. So I don't know if
> it is worth the regression risk, and I don't blame you if you delete
> this message without looking carefully. ;)
>
> Diff is kind of hard to read, so you may want to apply (on top of your
> patches) and just look at the post-image.
Thanks. For now though I think I prefer to go with the simpler diff that
uses goto, as it feels less risky close to v2.48. We can still refactor
this in the next release cycle.
Patrick
next prev parent reply other threads:[~2025-01-06 11:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 8:19 [PATCH 0/2] object-file: retry linking file into place when occluding file vanishes Patrick Steinhardt
2025-01-03 8:19 ` [PATCH 1/2] object-file: rename variables in `check_collision()` Patrick Steinhardt
2025-01-03 19:10 ` Jeff King
2025-01-03 8:19 ` [PATCH 2/2] object-file: retry linking file into place when occluding file vanishes Patrick Steinhardt
2025-01-03 16:18 ` Junio C Hamano
2025-01-03 19:40 ` Jeff King
2025-01-03 19:59 ` Jeff King
2025-01-03 22:29 ` Junio C Hamano
2025-01-06 11:11 ` Patrick Steinhardt [this message]
2025-01-07 1:25 ` Jeff King
2025-01-03 20:25 ` Junio C Hamano
2025-01-06 11:11 ` Patrick Steinhardt
2025-01-06 9:24 ` [PATCH v2 0/3] " Patrick Steinhardt
2025-01-06 9:24 ` [PATCH v2 1/3] object-file: rename variables in `check_collision()` Patrick Steinhardt
2025-01-06 9:24 ` [PATCH v2 2/3] object-file: don't special-case missing source file in collision check Patrick Steinhardt
2025-01-06 9:24 ` [PATCH v2 3/3] object-file: retry linking file into place when occluding file vanishes Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3u6c1UVQyZuHLdk@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).