Re: [PATCH] t7407: use test_grep

[Patrick Steinhardt <ps@pks.im>]

On Tue, Jan 07, 2025 at 02:18:24AM -0500, Jeff King wrote:
> There are a few grep calls here that can benefit from test_grep, which
> produces more user-friendly output when it fails.
> 
> One of these calls also passes "-sq", which is curious. The "-q" option
> suppresses the matched output. But test output is either already
> redirected to /dev/null in non-verbose mode, and in verbose mode it's
> better to see the output. The "-s" option suppresses errors opening
> files, but we are just grepping in the "expected" file we just
> generated, so it should not be needed. Neither of these was really
> hurting anything, but they are not a style we'd like to see emulated. So
> get rid of them.
> 
> (It is also curious to grep in the expected file in the first place, but
> that is because we are auto-generating the expectation from a Git
> command. So this is double-checking it did what we wanted).
> 
> Signed-off-by: Jeff King <peff@peff.net>

Thanks, both of these look obviously good to me.

Patrick