From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 00/10] reftable: fix -Wsign-compare warnings
Date: Mon, 20 Jan 2025 16:10:06 +0100 [thread overview]
Message-ID: <Z45nTojf3D6hDdMk@pks.im> (raw)
In-Reply-To: <CAOLa=ZQXF8ewDVmusbXPSCPPp9qqj2JRTvZeiiDZRckG5BpV6g@mail.gmail.com>
On Mon, Jan 20, 2025 at 05:07:23AM -0500, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > Hi,
> >
> > during the last steps of converting the reftable codebase to become a
> > standalone library I noticed that the new -Wsign-compare warnings
> > created a bit of a problem due to the `DISABLE_SIGN_COMPARE_WARNINGS`
> > macro that we started using. As a consequence I wasn't able to easily
> > drop "git-compat-util.h" anymore. This patch series is thus addresses
> > the issue by fixing all sign comparison warnings in the reftable
> > library.
> >
> > Thanks!
> >
>
> Most of the patches were straightforward and look good. I left only nits
> on one commit, which doesn't warrant a re-roll.
Thanks for your review! I'll send v2 in a bit.
Patrick
next prev parent reply other threads:[~2025-01-20 15:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 10:08 [PATCH 00/10] reftable: fix -Wsign-compare warnings Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 01/10] meson: stop disabling -Wsign-compare Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 02/10] reftable/record: drop unused `print` function pointer Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 03/10] reftable/record: handle overflows when decoding varints Patrick Steinhardt
2025-01-20 9:47 ` Karthik Nayak
2025-01-20 15:09 ` Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 04/10] reftable/basics: adjust `common_prefix_size()` to return `size_t` Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 05/10] reftable/basics: adjust `hash_size()` to return `uint32_t` Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 06/10] reftable/block: adapt header and footer size to return a `size_t` Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 07/10] reftable/block: adjust type of the restart length Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 08/10] reftable/blocksource: adjust type of the block length Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 09/10] reftable/blocksource: adjust `read_block()` to return `ssize_t` Patrick Steinhardt
2025-01-16 10:08 ` [PATCH 10/10] reftable: address trivial -Wsign-compare warnings Patrick Steinhardt
2025-01-16 22:12 ` Junio C Hamano
2025-01-17 6:10 ` Patrick Steinhardt
2025-01-20 10:07 ` [PATCH 00/10] reftable: fix " Karthik Nayak
2025-01-20 15:10 ` Patrick Steinhardt [this message]
2025-01-20 16:17 ` [PATCH v2 " Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 01/10] meson: stop disabling -Wsign-compare Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 02/10] reftable/record: drop unused `print` function pointer Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 03/10] reftable/record: handle overflows when decoding varints Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 04/10] reftable/basics: adjust `common_prefix_size()` to return `size_t` Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 05/10] reftable/basics: adjust `hash_size()` to return `uint32_t` Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 06/10] reftable/block: adapt header and footer size to return a `size_t` Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 07/10] reftable/block: adjust type of the restart length Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 08/10] reftable/blocksource: adjust type of the block length Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 09/10] reftable/blocksource: adjust `read_block()` to return `ssize_t` Patrick Steinhardt
2025-01-20 16:17 ` [PATCH v2 10/10] reftable: address trivial -Wsign-compare warnings Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z45nTojf3D6hDdMk@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).