From: Patrick Steinhardt <ps@pks.im>
To: "Jean-Noël Avila via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Jean-Noël Avila" <jn.avila@free.fr>
Subject: Re: [PATCH v2 5/5] doc: migrate git-commit manpage secondary files to new format
Date: Thu, 16 Jan 2025 11:17:17 +0100 [thread overview]
Message-ID: <Z4jcrX_tH0xfGKPh@pks.im> (raw)
In-Reply-To: <28316a709da913c624873291d96ed5aeddc6fc90.1736972628.git.gitgitgadget@gmail.com>
On Wed, Jan 15, 2025 at 08:23:48PM +0000, Jean-Noël Avila via GitGitGadget wrote:
> From: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <jn.avila@free.fr>
I would've liked to see a small description of what this does and also
provide a bit more context in the other commit messages instead of the
bulleted lists you have. They don't give the reader much of a sense of
the context we're operating in and why we think that those changes are
good.
Other than that the patch series looks fine to me. Thanks!
Patrick
prev parent reply other threads:[~2025-01-16 10:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 13:47 [PATCH 0/3] Doc git commit Jean-Noël Avila via GitGitGadget
2025-01-03 13:47 ` [PATCH 1/3] doc: git-commit: apply new documentation guidelines Jean-Noël Avila via GitGitGadget
2025-01-06 7:38 ` Patrick Steinhardt
2025-01-07 21:14 ` Jean-Noël AVILA
2025-01-03 13:47 ` [PATCH 2/3] doc: git-commit.txt: convert git commit config to new format Jean-Noël Avila via GitGitGadget
2025-01-03 13:47 ` [PATCH 3/3] doc: git-commit: migrate secondary files " Jean-Noël Avila via GitGitGadget
2025-01-15 20:23 ` [PATCH v2 0/5] Doc git commit Jean-Noël Avila via GitGitGadget
2025-01-15 20:23 ` [PATCH v2 1/5] doc: apply new documentation guidelines to " Jean-Noël Avila via GitGitGadget
2025-01-15 23:46 ` Junio C Hamano
2025-01-15 20:23 ` [PATCH v2 2/5] doc: the mode param of -u of git commit is optional Jean-Noël Avila via GitGitGadget
2025-01-15 20:23 ` [PATCH v2 3/5] doc: make more direct explanations in git commit options Jean-Noël Avila via GitGitGadget
2025-01-15 20:23 ` [PATCH v2 4/5] doc: convert git commit config to new format Jean-Noël Avila via GitGitGadget
2025-01-15 23:49 ` Junio C Hamano
2025-01-15 20:23 ` [PATCH v2 5/5] doc: migrate git-commit manpage secondary files " Jean-Noël Avila via GitGitGadget
2025-01-16 10:17 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4jcrX_tH0xfGKPh@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jn.avila@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).