Re: [PATCH 1/3] refs: mark `ref_transaction_update_reflog()` as static

[Patrick Steinhardt <ps@pks.im>]

On Fri, Jan 17, 2025 at 08:59:12AM +0100, Karthik Nayak wrote:
> diff --git a/refs.h b/refs.h
> index a0cdd99250e8286b55808b697b0a94afac5d8319..09be47afbee51e99f4ae49588cd65596ccfcb07e 100644
> --- a/refs.h
> +++ b/refs.h
> @@ -771,20 +771,6 @@ int ref_transaction_update(struct ref_transaction *transaction,
>  			   unsigned int flags, const char *msg,
>  			   struct strbuf *err);
>  
> -/*
> - * Similar to`ref_transaction_update`, but this function is only for adding
> - * a reflog update. Supports providing custom committer information. The index
> - * field can be utiltized to order updates as desired. When not used, the
> - * updates default to being ordered by refname.
> - */

Do we maybe want to move the comment over? The explanation of the index
field seems useful to me.

Patrick

> -int ref_transaction_update_reflog(struct ref_transaction *transaction,
> -				  const char *refname,
> -				  const struct object_id *new_oid,
> -				  const struct object_id *old_oid,
> -				  const char *committer_info, unsigned int flags,
> -				  const char *msg, unsigned int index,
> -				  struct strbuf *err);
> -
>  /*
>   * Add a reference creation to transaction. new_oid is the value that
>   * the reference should have after the update; it must not be