From: Patrick Steinhardt <ps@pks.im>
To: M Hickford via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, M Hickford <mirth.hickford@gmail.com>
Subject: Re: [PATCH 0/2] meson: wire up contrib/credential
Date: Fri, 14 Feb 2025 05:53:56 +0100 [thread overview]
Message-ID: <Z67MZJbGr0EqOMqT@pks.im> (raw)
In-Reply-To: <pull.1859.git.1739471859.gitgitgadget@gmail.com>
On Thu, Feb 13, 2025 at 06:37:37PM +0000, M Hickford via GitGitGadget wrote:
> It would be neat to also run test t0303-credential-external with
> GIT_TEST_CREDENTIAL_HELPER=wincred but I couldn't figure out how to do this.
Thanks for working on this! I have a patch series sitting locally for a
while that wires up all credential helpers and more, as well. It also
wires up netrc and fixes its tests to allow out-of-tree testing, which
doesn't work right now. What I don't have though is the patch for the
wincred helper.
The patch series is currently still blocked on [1], which is why I have
been holding back on it. Would you mind if I picked your patch to fix
wincred, but we then wait with wiring up remaining credential helpers
until my follow-up patch series is unblocked?
Meanwhile, I'd appreciate any feedback on [1] to help move it forward,
if you have the time :)
Patrick
[1]: <20250129-b4-pks-meson-improvements-v1-0-ab709f0be12c@pks.im>
prev parent reply other threads:[~2025-02-14 4:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 18:37 [PATCH 0/2] meson: wire up contrib/credential M Hickford via GitGitGadget
2025-02-13 18:37 ` [PATCH 1/2] meson: wire up credential-wincred M Hickford via GitGitGadget
2025-02-13 18:37 ` [PATCH 2/2] meson: wire up credential-libsecret M Hickford via GitGitGadget
2025-02-14 4:53 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z67MZJbGr0EqOMqT@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=mirth.hickford@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox