[PATCH] contrib/vscode: respect configurable options of IntelliSense

[PATCH] contrib/vscode: respect configurable options of IntelliSense

[Zejun Zhao]

The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.

Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.

Signed-off-by: Zejun Zhao <jelly.zhao.42@gmail.com>
---
 contrib/vscode/init.sh | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
index f2d61bb0e6..17f5b6161e 100755
--- a/contrib/vscode/init.sh
+++ b/contrib/vscode/init.sh
@@ -15,8 +15,7 @@ die "Could not create .vscode/"
 
 cat >.vscode/settings.json.new <<\EOF ||
 {
-    "C_Cpp.intelliSenseEngine": "Default",
-    "C_Cpp.intelliSenseEngineFallback": "Disabled",
+    "C_Cpp.intelliSenseEngine": "default",
     "[git-commit]": {
         "editor.wordWrap": "wordWrapColumn",
         "editor.wordWrapColumn": 72
@@ -203,8 +202,8 @@ cat >.vscode/settings.json.new <<\EOF ||
         "\\Wchar *\\*\\W*utfs\\W",
         "cURL's",
         "nedmalloc'ed",
-        "ntifs\\.h",
-    ],
+        "ntifs\\.h"
+    ]
 }
 EOF
 die "Could not write settings.json"

base-commit: f93ff170b93a1782659637824b25923245ac9dd1
-- 
2.43.0

Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense

[Patrick Steinhardt]

On Tue, Feb 04, 2025 at 12:57:21PM +0000, Zejun Zhao wrote:
> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.
> 
> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.

Formatting of the commit message is off, as we wrap lines at 72
characters. I cannot really say much about the patch itself. One thing
that might help reviewers who aren't familiar with VSCode would be a
link to for example release notes that announce the dremoval of the
option you're removing.

A bit off-topic: did you by any chance try out our Meson build system?
VSCode has a plugin for Meson that you can install, and then you can
import the Git project into VSCode directly without using
"contrib/vscode".

Patrick

Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense

[Johannes Schindelin]

Hi Zejun,

On Tue, 4 Feb 2025, Zejun Zhao wrote:

> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.
>
> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.
>
> Signed-off-by: Zejun Zhao <jelly.zhao.42@gmail.com>
> ---
>  contrib/vscode/init.sh | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
> index f2d61bb0e6..17f5b6161e 100755
> --- a/contrib/vscode/init.sh
> +++ b/contrib/vscode/init.sh
> @@ -15,8 +15,7 @@ die "Could not create .vscode/"
>
>  cat >.vscode/settings.json.new <<\EOF ||
>  {
> -    "C_Cpp.intelliSenseEngine": "Default",
> -    "C_Cpp.intelliSenseEngineFallback": "Disabled",
> +    "C_Cpp.intelliSenseEngine": "default",

This looks good to me!

Thank you,
Johannes

>      "[git-commit]": {
>          "editor.wordWrap": "wordWrapColumn",
>          "editor.wordWrapColumn": 72
> @@ -203,8 +202,8 @@ cat >.vscode/settings.json.new <<\EOF ||
>          "\\Wchar *\\*\\W*utfs\\W",
>          "cURL's",
>          "nedmalloc'ed",
> -        "ntifs\\.h",
> -    ],
> +        "ntifs\\.h"
> +    ]
>  }
>  EOF
>  die "Could not write settings.json"
>
> base-commit: f93ff170b93a1782659637824b25923245ac9dd1
> --
> 2.43.0
>
>
>

Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense

[Junio C Hamano]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi Zejun,
>
> On Tue, 4 Feb 2025, Zejun Zhao wrote:
>
>> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.
>>
>> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.

Overly long lines.  Please wrap lines in your proposed log message
at around 70 cols or so.

It explains why removing "fallback" is the right thing to do, but
it also wants to explain why we favor "default" over "Default" (and
if there is no good reason, that change should be reverted).

>> Signed-off-by: Zejun Zhao <jelly.zhao.42@gmail.com>
>> ---

Other than that, thanks for writing, and thanks for reviewing.

>>  contrib/vscode/init.sh | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
>> index f2d61bb0e6..17f5b6161e 100755
>> --- a/contrib/vscode/init.sh
>> +++ b/contrib/vscode/init.sh
>> @@ -15,8 +15,7 @@ die "Could not create .vscode/"
>>
>>  cat >.vscode/settings.json.new <<\EOF ||
>>  {
>> -    "C_Cpp.intelliSenseEngine": "Default",
>> -    "C_Cpp.intelliSenseEngineFallback": "Disabled",
>> +    "C_Cpp.intelliSenseEngine": "default",
>
> This looks good to me!
>
> Thank you,
> Johannes

>
>>      "[git-commit]": {
>>          "editor.wordWrap": "wordWrapColumn",
>>          "editor.wordWrapColumn": 72
>> @@ -203,8 +202,8 @@ cat >.vscode/settings.json.new <<\EOF ||
>>          "\\Wchar *\\*\\W*utfs\\W",
>>          "cURL's",
>>          "nedmalloc'ed",
>> -        "ntifs\\.h",
>> -    ],
>> +        "ntifs\\.h"
>> +    ]
>>  }
>>  EOF
>>  die "Could not write settings.json"
>>
>> base-commit: f93ff170b93a1782659637824b25923245ac9dd1
>> --
>> 2.43.0
>>
>>
>>