From: Patrick Steinhardt <ps@pks.im>
To: Elijah Newren <newren@gmail.com>
Cc: "David Aguilar" <davvid@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 3/3] difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE
Date: Fri, 7 Feb 2025 07:28:34 +0100 [thread overview]
Message-ID: <Z6WoEjEo9Seffm_q@pks.im> (raw)
In-Reply-To: <CABPp-BGi51EQvPOgaz8p0RjAJ0zDDeTpMDp__puz_wQH5wowXw@mail.gmail.com>
On Thu, Feb 06, 2025 at 12:31:14AM -0800, Elijah Newren wrote:
> On Wed, Feb 5, 2025 at 8:20 PM David Aguilar <davvid@gmail.com> wrote:
> >
> > Remove the USE_THE_REPOSITORY_VARIABLE #define now that all
> > state is passed to each function from callers.
> >
> > Signed-off-by: David Aguilar <davvid@gmail.com>
> > ---
> > builtin/difftool.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/builtin/difftool.c b/builtin/difftool.c
> > index 81d733dfdf..41cd00066c 100644
> > --- a/builtin/difftool.c
> > +++ b/builtin/difftool.c
> > @@ -12,8 +12,6 @@
> > * Copyright (C) 2016 Johannes Schindelin
> > */
> >
> > -#define USE_THE_REPOSITORY_VARIABLE
> > -
> > #include "builtin.h"
> >
> > #include "abspath.h"
> > --
> > 2.48.1.461.g612e419e04
>
>
> Nice; thanks for working on this.
Yup, thanks for rerolling. This version is much easier to read indeed
and looks good to me.
Patrick
next prev parent reply other threads:[~2025-02-07 6:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 4:20 [PATCH v2 1/3] difftool: eliminate use of global variables David Aguilar
2025-02-06 4:20 ` [PATCH v2 2/3] difftool: eliminate use of the_repository David Aguilar
2025-02-06 8:30 ` Elijah Newren
2025-02-06 4:20 ` [PATCH v2 3/3] difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE David Aguilar
2025-02-06 8:31 ` Elijah Newren
2025-02-07 6:28 ` Patrick Steinhardt [this message]
2025-02-07 17:49 ` Junio C Hamano
2025-02-06 8:29 ` [PATCH v2 1/3] difftool: eliminate use of global variables Elijah Newren
2025-02-07 4:44 ` David Aguilar
2025-02-06 13:34 ` Junio C Hamano
2025-02-06 18:08 ` Elijah Newren
2025-02-06 19:07 ` Junio C Hamano
2025-02-07 6:28 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6WoEjEo9Seffm_q@pks.im \
--to=ps@pks.im \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).