From: Patrick Steinhardt <ps@pks.im>
To: Lucas Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [GSoC][PATCH] t7603: replace test -f by test_path_is_file
Date: Mon, 10 Feb 2025 07:48:51 +0100 [thread overview]
Message-ID: <Z6mhU50bt5iYVuZ8@pks.im> (raw)
In-Reply-To: <20250208165731.78804-1-lucasseikioshiro@gmail.com>
On Sat, Feb 08, 2025 at 01:57:31PM -0300, Lucas Oshiro wrote:
> `test_path_is_file` provides a better output when asserting whether a
> file exists. Replace the occurrences of `test -f` in 7603 by it,
Tiny nit, which probably does not warrant a reroll: it would be nice to
consistently refer to test suites with the "t" prefix, so here you'd say
"t7603" instead of just "7603".
The changes themselv look good to me, thanks!
Patrick
prev parent reply other threads:[~2025-02-10 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 16:57 [GSoC][PATCH] t7603: replace test -f by test_path_is_file Lucas Oshiro
2025-02-10 6:48 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6mhU50bt5iYVuZ8@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=lucasseikioshiro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).